Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature parity for s3 compliant providers #446

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Add feature parity for s3 compliant providers #446

merged 1 commit into from
Mar 2, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Feb 25, 2022 •
edited
Loading

What this PR does / why we need it:
This PR adds support for S3 compatible providers (see #431) when configuration is passed via secrets.

Release note:

None

@timuthy timuthy requested a review from a team as a code owner February 25, 2022 07:07
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 25, 2022
@timuthy timuthy force-pushed the feature.s3-comp-providers branch from 1a3919b to d5b285a Compare February 25, 2022 07:07
@timuthy
Copy link
Member Author

timuthy commented Feb 25, 2022

/invite @ishan16696

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 25, 2022
@timuthy timuthy added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 28, 2022
@ishan16696
Copy link
Member

@timuthy Can you resolve the merge conflicts ?

ishan16696
ishan16696 requested changes Mar 2, 2022
View reviewed changes
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Mar 2, 2022
@timuthy timuthy force-pushed the feature.s3-comp-providers branch from d5b285a to 72ae1f3 Compare March 2, 2022 10:53
@timuthy
Copy link
Member Author

timuthy commented Mar 2, 2022

Thanks for the review @ishan16696. PTAL.

@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 2, 2022
ishan16696
ishan16696 approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishan16696 ishan16696 merged commit 9ea53cd into gardener:master Mar 2, 2022
@timuthy timuthy deleted the feature.s3-comp-providers branch March 2, 2022 14:20
@ishan16696 ishan16696 mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timuthy @ishan16696 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot