Enhancement: Implement Chunk Deletion for Multi-part Uploaded Files on GCP and Openstack Cloud Providers #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…triggered instead of waiting for the chunks to get deleted when the corresponding snapshot is garbage collected
… object is uploaded
|
|
gardener-robot
added
needs/review
|
Thank you @anveshreddy18 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
seshachalam-yv
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
seshachalam-yv
requested changes
Nov 7, 2023
…ext timeout * Timeout same as chunk upload timeout * Collected individual chunk deletion errors into a errList * Affected code: Gcs & Swift snapstore chunk deletion
gardener-robot
added
size/m
anveshreddy18
added
reviewed/ok-to-test
|
Context:: After discussing the need for immediate chunk deletion, it is decided that we don't need to make it complex and also functionality wise, it should be done by GC so letting GC delete the chunks. My recent commit has changes according to that. Please take a look once @seshachalam-yv @ishan16696 |
Thanks @anveshreddy18 for changes, please change the release note accordingly to reflect the functionality. |
seshachalam-yv
requested changes
Nov 22, 2023
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
ishan16696
reviewed
Nov 22, 2023
ishan16696
approved these changes
Nov 22, 2023
gardener-robot
added
the
status/closed
ishan16696
pushed a commit
to ishan16696/etcd-backup-restore
that referenced
this pull request
Nov 22, 2023
…n GCP and Openstack Cloud Providers (gardener#673) * Added generic functionality to garbage collect the chunks when GC is triggered instead of waiting for the chunks to get deleted when the corresponding snapshot is garbage collected * Deleting chunks from GCS bucket immediately after the composite object is uploaded * Deleting chunks from OpenStack bucket immediately after the composite object is uploaded * Add logs for count of chunks getting deleted * Updated comments and code for readability * Fixed a bug in tests * Transfer the immediate chunk deletion logic to new function with context timeout * Timeout same as chunk upload timeout * Collected individual chunk deletion errors into a errList * Affected code: Gcs & Swift snapstore chunk deletion * Add logs after successfully performing chunk deletion * Fix snapstore tests, update comments * Parallelize chunk deletion * For better performance * To prevent blocking the snapshotter while chunk deletion for older snapshot is underway * Add comment * Add mutex to prevent DATA RACE in ObjectMap of mock GCS & Swift clients while deleting chunks in parallel * Minor fixes * Add mutex to prevent parallel read & write for GCS Mock client * Improved error collection in chunk deletion * Remove immediate chunk deletion, address edge case in Garbage Collection * Address review comments * Minor fixes
ishan16696
added a commit
that referenced
this pull request
Nov 22, 2023
…n GCP and Openstack Cloud Providers (#673) (#682) * Added generic functionality to garbage collect the chunks when GC is triggered instead of waiting for the chunks to get deleted when the corresponding snapshot is garbage collected * Deleting chunks from GCS bucket immediately after the composite object is uploaded * Deleting chunks from OpenStack bucket immediately after the composite object is uploaded * Add logs for count of chunks getting deleted * Updated comments and code for readability * Fixed a bug in tests * Transfer the immediate chunk deletion logic to new function with context timeout * Timeout same as chunk upload timeout * Collected individual chunk deletion errors into a errList * Affected code: Gcs & Swift snapstore chunk deletion * Add logs after successfully performing chunk deletion * Fix snapstore tests, update comments * Parallelize chunk deletion * For better performance * To prevent blocking the snapshotter while chunk deletion for older snapshot is underway * Add comment * Add mutex to prevent DATA RACE in ObjectMap of mock GCS & Swift clients while deleting chunks in parallel * Minor fixes * Add mutex to prevent parallel read & write for GCS Mock client * Improved error collection in chunk deletion * Remove immediate chunk deletion, address edge case in Garbage Collection * Address review comments * Minor fixes Co-authored-by: Anvesh Reddy Pinnapureddy <anvesh.reddy.pinnapureddy@sap.com>
ishan16696
assigned shreyas-s-rao and unassigned ishan16696, shreyas-s-rao and seshachalam-yv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After the snapshots are uploaded as multiple parts (Chunks) to cloud storage buckets, chunks are not auto-deleted on a few cloud providers. Out of the providers we use, GCP & OpenStack does not delete the chunks after forming composite object. These chunks take up space equal to its corresponding composite object. With this PR, storage occupancy & cost of the bucket can be reduced to half.
Added functionality in GC to delete chunks
Which issue(s) this PR fixes:
Fixes #268
Special notes for your reviewer:
Release note: