-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to member lease annotation for peer URL TLS is now done by making a member API call #716
Conversation
…by making member API call
@unmarshall You need rebase this pull request with latest master branch. Please check. |
/assign |
In an out of bands discussion it was mentioned that this PR would not be necessary for gardener/etcd-druid#777 to be merged, could this be elaborated further here for documenting why so? Please correct me if my understanding is wrong. |
As per Update advertise peer URLs it was understood that one needs to call member API to update the peer URL and then restart the member for it come into effect. In the current code in master STS component first updates the STS mounting the peer secret volume (this causes a rolling update thus resulting in backup-restore taking the latest config map which contains the changed peer url). Once the backup-restore container restarts as part of initialization it makes the In another case where there is a 3 member cluster and now replicas are increased to 5 and TLS is enabled then one restart would no longer be sufficient. However in this case this PR will still not be useful. |
/close since we don't need this PR for scale-up of etcds in gardener/etcd-druid#777 |
What this PR does / why we need it:
Update to member lease annotation for peer URL TLS is now done by making a member API call which accurately depicts the status of the enablement of change of peer URL TLS as seen by the etcd process. Previously only mounted configmap was looked at which is not sufficient as an additional restart of the etcd process is required for this to be reflected in the etcd member.
Which issue(s) this PR fixes:
Fixes Part of #712
Special notes for your reviewer:
Release note: