Upgrade ABS client Go module to `azure-sdk-for-go/sdk/storage/azblob` #751

renormalize · 2024-07-22T03:57:25Z

What this PR does / why we need it:

Upgrades the client Go modules for ABS to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from the deprecated github.com/Azure/azure-storage-blob-go

Which issue(s) this PR fixes:
Fixes #745

Release note:

Azure Blob Storage client Go module upgraded to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from the deprecated github.com/Azure/azure-storage-blob-go

anveshreddy18 · 2024-07-25T10:53:04Z

/assign

pkg/snapstore/abs_snapstore.go

ishan16696 · 2024-07-31T08:04:49Z

/assign

pkg/snapstore/abs_snapstore.go

pkg/snapstore/abs_snapstore_test.go

pkg/snapstore/abs_snapstore.go

pkg/snapstore/abs_snapstore_test.go

renormalize · 2024-08-14T05:07:49Z

Thanks for your review @ishan16696!

Will let you know once the other PRs get merged and I resolve the conflicts.

@anveshreddy18

…or-go` * Elimiated usage of the old `Azure/azure-storage-blob-go` in `pkg/snapstore/abs_snapstore.go`. * Used functionality provided by `Azure/azure-sdk-for-go` in `pkg/snapstore/abs_snapstore.go`. * Methods on `ABSSnapStore` work as intended after the change. Unit tests refactored for the new SDK. `abs_snapstore_test.go` cleanup. Ran `go mod tidy`, `go mod vendor` Address review comments from @anveshreddy18. Address review comments from @ishan16696 1. * Remove variable names from interface type definitions * Make use of `streaming.NopCloser()` to create a no-op `Close()` for a `ReadSeekCloser`, instead of redefining the type. * Fix typo pointed out by @anveshreddy18 Address review comments from @ishan16696 2. * Nit change: change `context.TODO()` to `context.Background()`. Rebased on PR 759.

ishan16696 · 2024-08-21T09:38:42Z

pkg/snapstore/abs_snapstore_test.go

+type fakeABSContainerClient struct {
+	objects map[string]*[]byte
+	prefix  string
+	mutex   sync.Mutex
+	// a map of blobClients so new clients created to a particular blob refer to the same blob
+	blobClients map[string]*fakeBlockBlobClient


do you want to mock the AzureBlockBlob Client ?

//go:generate mockgen -package <name> -destination=mocks.go github.com/gardener/etcd-backup-restore/pkg/snapstore/ AzureBlockBlobClientI

you can take a look at this package:

etcd-backup-restore/pkg/mock/etcdutil/client/doc.go

Line 4 in 5d011d7

//go:generate mockgen -package client -destination=mocks.go github.com/gardener/etcd-backup-restore/pkg/etcdutil/client Factory,ClusterCloser,KVCloser,MaintenanceCloser

I will leave this to another PR. Will create an issue to track this later.

can you create an issue for it and mentioned it here.

I've created an issue to track this. #772.

pkg/snapstore/abs_snapstore.go

ishan16696

Thanks for all changes. LGTM!!

pkg/snapstore/abs_snapstore.go

pkg/snapstore/abs_snapstore_test.go

anveshreddy18

LGTM

renormalize requested a review from a team as a code owner July 22, 2024 03:57

gardener-robot added the needs/review Needs review label Jul 22, 2024

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024

gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 22, 2024

renormalize self-assigned this Jul 22, 2024

renormalize added this to the v0.30.0 milestone Jul 22, 2024

gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2024

renormalize force-pushed the azblob branch from 6229259 to 9efc65a Compare July 23, 2024 08:46

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024

renormalize force-pushed the azblob branch from 9efc65a to 9341dd4 Compare July 23, 2024 08:54

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 23, 2024

gardener-robot assigned anveshreddy18 Jul 25, 2024

renormalize assigned unmarshall Jul 25, 2024

anveshreddy18 reviewed Jul 25, 2024

View reviewed changes

pkg/snapstore/abs_snapstore.go Outdated Show resolved Hide resolved

renormalize force-pushed the azblob branch from 9341dd4 to ae039c0 Compare July 26, 2024 09:57

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 26, 2024

gardener-robot assigned ishan16696 Jul 31, 2024

renormalize unassigned unmarshall Aug 5, 2024

anveshreddy18 requested changes Aug 7, 2024

View reviewed changes

gardener-robot added the needs/changes Needs (more) changes label Aug 7, 2024

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2024

ishan16696 requested changes Aug 9, 2024

View reviewed changes

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 14, 2024

renormalize force-pushed the azblob branch from b5ab3a4 to 64c2467 Compare August 19, 2024 08:16

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 19, 2024

shreyas-s-rao modified the milestones: v0.30.0, v0.31.0 Aug 21, 2024

ishan16696 reviewed Aug 21, 2024

View reviewed changes

renormalize mentioned this pull request Sep 4, 2024

[Enhancement] Use mockgen to generate mock clients for ABS #772

Open

ishan16696 reviewed Sep 4, 2024

View reviewed changes

pkg/snapstore/abs_snapstore.go Outdated Show resolved Hide resolved

pkg/snapstore/abs_snapstore.go Outdated Show resolved Hide resolved

ishan16696 requested changes Sep 4, 2024

View reviewed changes

pkg/snapstore/abs_snapstore.go Outdated Show resolved Hide resolved

pkg/snapstore/abs_snapstore.go Outdated Show resolved Hide resolved

Address review comments from @ishan16696 3.

a28d289

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 4, 2024

ishan16696 reviewed Sep 5, 2024

View reviewed changes

pkg/snapstore/abs_snapstore.go Outdated Show resolved Hide resolved

Address review comments from @ishan16696 4.

f316325

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2024

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2024

ishan16696 approved these changes Sep 5, 2024

View reviewed changes

ishan16696 removed their assignment Sep 5, 2024

anveshreddy18 requested changes Sep 6, 2024

View reviewed changes

pkg/snapstore/abs_snapstore.go Show resolved Hide resolved

pkg/snapstore/abs_snapstore_test.go Outdated Show resolved Hide resolved

pkg/snapstore/abs_snapstore_test.go Outdated Show resolved Hide resolved

Address review comments from @anveshreddy18 1.

e17fdbb

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 6, 2024

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 6, 2024

anveshreddy18 approved these changes Sep 6, 2024

View reviewed changes

ishan16696 unassigned anveshreddy18 Sep 9, 2024

renormalize merged commit 7e78860 into gardener:master Sep 9, 2024
9 checks passed

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 9, 2024

renormalize deleted the azblob branch November 15, 2024 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade ABS client Go module to `azure-sdk-for-go/sdk/storage/azblob` #751

Upgrade ABS client Go module to `azure-sdk-for-go/sdk/storage/azblob` #751

renormalize commented Jul 22, 2024

anveshreddy18 commented Jul 25, 2024

ishan16696 commented Jul 31, 2024

renormalize commented Aug 14, 2024

ishan16696 Aug 21, 2024 •

edited

Loading

renormalize Aug 29, 2024

ishan16696 Sep 4, 2024

renormalize Sep 4, 2024

ishan16696 left a comment

anveshreddy18 left a comment

Upgrade ABS client Go module to azure-sdk-for-go/sdk/storage/azblob #751

Upgrade ABS client Go module to azure-sdk-for-go/sdk/storage/azblob #751

Conversation

renormalize commented Jul 22, 2024

anveshreddy18 commented Jul 25, 2024

ishan16696 commented Jul 31, 2024

renormalize commented Aug 14, 2024

ishan16696 Aug 21, 2024 • edited Loading

Choose a reason for hiding this comment

renormalize Aug 29, 2024

Choose a reason for hiding this comment

ishan16696 Sep 4, 2024

Choose a reason for hiding this comment

renormalize Sep 4, 2024

Choose a reason for hiding this comment

ishan16696 left a comment

Choose a reason for hiding this comment

anveshreddy18 left a comment

Choose a reason for hiding this comment

Upgrade ABS client Go module to `azure-sdk-for-go/sdk/storage/azblob` #751

Upgrade ABS client Go module to `azure-sdk-for-go/sdk/storage/azblob` #751

ishan16696 Aug 21, 2024 •

edited

Loading