Skip to content

Commit

Permalink
minor doc string change
Browse files Browse the repository at this point in the history
  • Loading branch information
unmarshall committed Nov 12, 2024
1 parent 619c56c commit 9d5cc05
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/component/clientservice/clientservice.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func buildResource(etcd *druidv1alpha1.Etcd, svc *corev1.Service) {
svc.Spec.Type = corev1.ServiceTypeClusterIP
svc.Spec.SessionAffinity = corev1.ServiceAffinityNone
// Client service should only target StatefulSet pods. Default labels are going to be present on anything that is managed by etcd-druid and started for an etcd cluster.
// Therefore, only using this as a label selector can cause issues as we have already seen in https://github.com/gardener/etcd-druid/issues/914
// Therefore, only using default labels as label selector can cause issues as we have already seen in https://github.com/gardener/etcd-druid/issues/914
svc.Spec.Selector = utils.MergeMaps(druidv1alpha1.GetDefaultLabels(etcd.ObjectMeta), map[string]string{druidv1alpha1.LabelComponentKey: common.ComponentNameStatefulSet})
svc.Spec.Ports = getPorts(etcd)
}
Expand Down
2 changes: 1 addition & 1 deletion internal/component/peerservice/peerservice.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func buildResource(etcd *druidv1alpha1.Etcd, svc *corev1.Service) {
svc.Spec.ClusterIP = corev1.ClusterIPNone
svc.Spec.SessionAffinity = corev1.ServiceAffinityNone
// Peer service should only target StatefulSet pods. Default labels are going to be present on anything that is managed by etcd-druid and started for an etcd cluster.
// Therefore, only using this as a label selector can cause issues as we have already seen in https://github.com/gardener/etcd-druid/issues/914
// Therefore, only using default labels as label selector can cause issues as we have already seen in https://github.com/gardener/etcd-druid/issues/914
svc.Spec.Selector = utils.MergeMaps(druidv1alpha1.GetDefaultLabels(etcd.ObjectMeta), map[string]string{druidv1alpha1.LabelComponentKey: common.ComponentNameStatefulSet})
svc.Spec.PublishNotReadyAddresses = true
svc.Spec.Ports = getPorts(etcd)
Expand Down

0 comments on commit 9d5cc05

Please sign in to comment.