-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Druid to use mock GCS server to run e2e tests #741
base: master
Are you sure you want to change the base?
Conversation
Thanks for the review @seshachalam-yv, can you pls test now. Earlier there was a hashtag infront of the svcacc.json field in the secret, hence you saw the failure to read the creds. I've now removed that, and updated the docs. Pls follow the latest doc to run it successfully. |
Could you create a new PR to bump the version of etcd-backup-restore? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's conflicts with the latest commit in master again now, can you resolve the conflicts? Thanks.
Address review comments Create gcp secret to use emulator for druid local setup Add documentation for usage of fake-gcs-server for e2e tests Add documentation to setup etcd-druid locally using fake-gcs-server Propagate changes made to etcdbr PR#697 Rename EMULATOR_ENABLED to GOOGLE_EMULATOR_ENABLED Upgrade etcdbr dependency to 0.29.0 for emulator support in e2e tests Address review comments by @seshachalam-yv Revert the etcdbr bump & address review comments
585d628
to
3af95c4
Compare
/retest |
/hold Needs some changes as |
How to categorize this PR?
/area dev-productivity
/area testing
/kind test
What this PR does / why we need it:
This PR enables druid to run e2e tests for GCS locally with the help of a GCS Emulator called
fake-gcs-server
.To run e2e tests with GCS Emulator as object store, do
make ci-e2e-kind-gcs
.Which issue(s) this PR fixes:
Fixes #738
Special notes for your reviewer:
Release note: