-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to support multi-node etcd clusters #115
Conversation
LGTM |
00ba348
to
2b32c53
Compare
2b32c53
to
bc5554b
Compare
bc5554b
to
89fd0de
Compare
89fd0de
to
cd27726
Compare
cd27726
to
0d27d09
Compare
Very nice and thorough write up, thanks!
|
@dguendisch Very interesting idea. I hadn't thought of that. I just checked the etcd configuration and unfortunately, there doesn't seem to be any explicit configuration that can put etcd clusters into read-only mode short of losing quorum. Forcibly losing quorum on backup failure sounds too drastic.
I am afraid I do not have too much experience. Only from local playing around, I would say leader election is quite fast. The heartbeats are Also, during leader election the writes are queued instead of rejected. So, writes experience more latency at worst. They may timeout, of course. https://etcd.io/docs/v3.1.12/op-guide/failures/#leader-failure. |
0d27d09
to
cad152b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you very much, very helpful. I have only a few nitpicks and proposals, but otherwise I found it very enlightening.
@vlerenc Thanks a lot for the suggestions! I have applied almost all of them 🙂 |
570f460
to
dd7852f
Compare
dd7852f
to
e06139c
Compare
I have addressed the review comments so far. I will merge this PR now. If there are more concerns, please do raise an issue :-) |
What this PR does / why we need it:
Proposal to support multi-node etcd clusters.
Credits:
@abdasgupta @shreyas-s-rao for extensive discussions and content.
@swapnilgm for initial discussions and first draft of implementation.
@istvanballok for many interesting ideas, especially,
tmpfs
.@vlerenc for many interesting inputs, including (but not limited to 🙂) ephemeral persistence and etcd container and backup-restore sidecar interaction.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is the proposal part of #107. The implementation will be done in further PRs.
Please find the human-friendly rendering of the document here (note: point in time).
Release note: