Introduced member leases to work-around limitations in Server-Side-Apply #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
gardener-robot-ci-2
added
the
reviewed/ok-to-test
1 task
gardener-robot-ci-3
added
needs/ok-to-test
amshuman-kr
force-pushed
the
intruduce-lease-for-members
branch
from
0065a16
to
5912322
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
timuthy
suggested changes
Jul 26, 2021
amshuman-kr
force-pushed
the
intruduce-lease-for-members
branch
from
5912322
to
442a557
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@timuthy Thanks for the review! I have addressed your comments. Can you please check if this fine or if more changes are required? |
timuthy
reviewed
Jul 27, 2021
timuthy
approved these changes
Jul 27, 2021
gardener-robot
added
reviewed/lgtm
There was a problem hiding this comment.
@amshuman-kr Thanks for updating the proposal with the changes from our discussion. I just had a doubt regarding the utility of id field over role field. Please address this. Thanks.
amshuman-kr
force-pushed
the
intruduce-lease-for-members
branch
from
442a557
to
cfe150f
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@shreyas-s-rao Thanks for the review. I have changed the proposal as discussed. Now both |
shreyas-s-rao
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
Introduced member leases to work-around limitations in Server-Side-Apply.
Which issue(s) this PR fixes:
Alternative design to #206.
Special notes for your reviewer:
Limitations in Server-Side Apply are documented in #179. I have updated the proposal with alternative design that was discussed out-of-band of using
leasesper member instead of introducing a newEtcdMemberresource (as described in #206).cc @shreyas-s-rao @timuthy @abdasgupta
Release note: