-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopped reconciliation if quorumloss annotation is set by operator. #446
Conversation
@abdasgupta Labels area/todo, kind/todo do not exist. |
@abdasgupta Labels area/todo, kind/todo do not exist. |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @abdasgupta! Looks good in general
One suggestion, consider using the annotation druid.gardener.cloud/ignore
instead as it's more semantically accurate
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
/lgtm
Please add an appropriate release note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdasgupta thanks for the PR. Can you please add a test for this?
Also, please update the PR note and add a release note too.
@shreyas-s-rao Any idea how to add a test case for this? This PR is just not reconciling on addition of the annotation |
@abdasgupta Labels area/todo, kind/todo do not exist. |
1 similar comment
@abdasgupta Labels area/todo, kind/todo do not exist. |
Updated the release note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @abdasgupta!
One nit and one suggestion from me
Please don't do a force-push it makes review difficult. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdasgupta Thanks for making the changes. Final few comments from my side.
Please also update the release note to add the full link to the document - https://github.com/gardener/etcd-druid/blob/master/docs/operation/Recover_From_Etcd_Permanent_Quorum_Loss.md
@abdasgupta Labels area/todo, kind/todo do not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdasgupta Thanks for making the requested changes.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area TODO
/kind TODO
What this PR does / why we need it:
This PR enables ETCD controller to check for an annotation named
druid.gardener.cloud/ignore-reconciliation
in ETCD CR. The annotation is applied by human operator who wants to recover a cluster from permanent quorum loss. The ETCD controller does not reconcile until the annotation is removed.Which issue(s) this PR fixes:
Fixes #
#437
Special notes for your reviewer:
Release note: