Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make max-backups configurable in LimitBased GC from etcd yaml with a new field maxBackupsLimitBasedGC in Etcd CR #755

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Make max-backups configurable in LimitBased GC from etcd yaml with a new field maxBackupsLimitBasedGC in Etcd CR #755

merged 5 commits into from
Jan 23, 2024

Conversation

anveshreddy18
Copy link
Contributor

@anveshreddy18 anveshreddy18 commented Jan 11, 2024 •
edited by ishan16696
Loading

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:

This PR adds a new field maxBackupsLimitBasedGC in the spec.backup section of Etcd yaml and makes necessary changes, which allows to configure max-backups parameter used for LimitBased GC.

  • At present, there is no way to configure the number of full snapshots to retain in a limitBased GC policy as a default value of 7 is set in the code.
  • This change will allow the user to configure the --max-backups flag of the etcd-statefulset thus allowing them to control the behaviour of Limit Based GC.

Note: It will be an optional field, when not set, max-backups will defaul to 7

Which issue(s) this PR fixes:
Fixes #754

Special notes for your reviewer:

Release note:

Enabling the configurability of `--max-backups` for LimitBasedGC through the etcd resource spec `.spec.backup.maxBackupsLimitBasedGC`.

@anveshreddy18 anveshreddy18 requested a review from a team as a code owner January 11, 2024 07:01
@gardener-robot gardener-robot added needs/review Needs review area/usability Usability related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 11, 2024
@anveshreddy18 anveshreddy18 self-assigned this Jan 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2024
@anveshreddy18 anveshreddy18 removed their assignment Jan 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 11, 2024
@anveshreddy18 anveshreddy18 changed the title Make max-backups configurable in LimitBased GC from etcd yaml with a new field maxBackupsLimitBased in Etcd CR Make max-backups configurable in LimitBased GC from etcd yaml with a new field maxBackupsLimitBased in Etcd CR Jan 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2024
@anveshreddy18 anveshreddy18 changed the title Make max-backups configurable in LimitBased GC from etcd yaml with a new field maxBackupsLimitBased in Etcd CR Make max-backups configurable in LimitBased GC from etcd yaml with a new field maxBackupsLimitBasedGC in Etcd CR Jan 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 11, 2024
@ishan16696
Copy link
Member

/test pull-etcd-druid-e2e-kind

1 similar comment
@ishan16696
Copy link
Member

/test pull-etcd-druid-e2e-kind

ishan16696
ishan16696 requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anveshreddy18 for PR, overall PR looks good.
just few nits

api/v1alpha1/types_etcd.go Outdated Show resolved Hide resolved
pkg/component/etcd/statefulset/values_helper.go Outdated Show resolved Hide resolved
api/v1alpha1/types_etcd.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jan 22, 2024
@ishan16696
Copy link
Member

@anveshreddy18 I have also updated the release note. Please take a look. Hope that's fine.

@anveshreddy18
Copy link
Contributor Author

anveshreddy18 commented Jan 22, 2024 •
edited
Loading

Thanks @ishan16696 for the review.

@anveshreddy18 I have also updated the release note. Please take a look. Hope that's fine.

Yes it's fine. Thanks!

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2024
ishan16696
ishan16696 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@anveshreddy18
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@ishan16696 ishan16696 added the merge/squash Should be merged via 'Squash and merge' label Jan 22, 2024
@anveshreddy18
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

3 similar comments
@ishan16696
Copy link
Member

/test pull-etcd-druid-e2e-kind

@anveshreddy18
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@ishan16696
Copy link
Member

/test pull-etcd-druid-e2e-kind

@anveshreddy18 anveshreddy18 merged commit 5cd5b1b into gardener:master Jan 23, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 23, 2024
@shreyas-s-rao shreyas-s-rao added this to the v0.23.0 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees

@anveshreddy18 anveshreddy18

Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

Make max-backups configurable in LimitBased GC from Etcd CR
6 participants
@anveshreddy18 @ishan16696 @gardener-robot-ci-1 @shreyas-s-rao @gardener-robot-ci-2 @gardener-robot