Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed g/g scripts dependency, updated gomod dependencies, adapted g… #834

Merged
merged 5 commits into from
Jul 24, 2024
Merged

removed g/g scripts dependency, updated gomod dependencies, adapted g… #834

merged 5 commits into from
Jul 24, 2024

Conversation

unmarshall
Copy link
Contributor

@unmarshall unmarshall commented Jul 22, 2024 •
edited
Loading

How to categorize this PR?

/area quality
/area open-source
/kind cleanup
/kind technical-debt

What this PR does / why we need it:

  1. Removes dependency on gardener/gardener hack/scripts.
  2. Updates gardener/gardener dependency to 1.99.1
  3. Updates controller-runtime k8s.io/*, logr, ginkgo, zap etc dependencies in go.mod
  4. Adapt code to fix issues reported by golanglint-ci
  5. etcd CRD has been updated to incorporate recent changes in kep-3633
  6. Go native unit tests now run concurrently. This was not completely done earlier.

Which issue(s) this PR fixes:
Fixes #503

Special notes for your reviewer:

Release note:

1. Dependency version upgrades done to gardener/gardener, controller-runtime, controller-tools, k8s.io/*, logr, zap, ginkgo, uber mock, uuid dependencies.
2. Adapted golanglint-ci recommendations.
3. Removed dependency on gardener/gardener hack/scripts.

@unmarshall unmarshall requested a review from a team as a code owner July 22, 2024 04:53
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/rebase Needs git rebase labels Jul 22, 2024
@gardener-robot
Copy link

@unmarshall You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
seshachalam-yv
seshachalam-yv approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unmarshall for removing g/g scripts dependency.
Nice PR ❤️
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
@renormalize
Copy link
Member

/assign

renormalize
renormalize reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unmarshall thanks for the PR!

Please take a look at the single comment from me.

Makefile Show resolved Hide resolved
renormalize
renormalize reviewed Jul 24, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jul 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 24, 2024
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 24, 2024
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

1 similar comment
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

@unmarshall unmarshall merged commit c73cbf9 into gardener:master Jul 24, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 24, 2024
@shreyas-s-rao shreyas-s-rao added this to the v0.23.0 milestone Jul 25, 2024
@ishan16696 ishan16696 mentioned this pull request Jul 25, 2024
Closed
@unmarshall unmarshall deleted the gscript branch August 12, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renormalize renormalize renormalize approved these changes

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees

@renormalize renormalize

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

Remove the dependency on g/g hack/scripts
8 participants
@unmarshall @gardener-robot @renormalize @seshachalam-yv @gardener-robot-ci-1 @shreyas-s-rao @gardener-robot-ci-2 @gardener-robot-ci-3