Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github PR template #962

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Update github PR template #962

merged 2 commits into from
Jan 1, 2025

Conversation

shreyas-s-rao
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind task

What this PR does / why we need it:
Update github PR template to replace information about raising GEPs, with DEPs instead.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner January 1, 2025 12:53
@gardener-robot gardener-robot added needs/review Needs review area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/task General task size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 1, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 1, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 1, 2025
renormalize
renormalize approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been pending for a while, thanks a lot for raising it!

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 1, 2025
@shreyas-s-rao
Copy link
Contributor Author

@renormalize thanks for the quick review. I also realised that make check-generate was failing. Reason being, when you run make generate, it generates new files with the SPDX docstring at the top of the file with a 2025 copyright, which doesn't match with the current 2024 copyright string in the generated file 😆 .

I've fixed that now. PTAL

@renormalize
Copy link
Member

@shreyas-s-rao feel free to merge this PR

@shreyas-s-rao shreyas-s-rao merged commit 3bf051b into gardener:master Jan 1, 2025
13 checks passed
@shreyas-s-rao shreyas-s-rao deleted the upd/github-pr-template branch January 1, 2025 13:34
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 1, 2025
@shreyas-s-rao
Copy link
Contributor Author

@renormalize thanks. Can you also please review similar PRs gardener/etcd-backup-restore#825 and gardener/etcd-wrapper#40 as well? Thanks!

@renormalize renormalize mentioned this pull request Jan 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renormalize renormalize renormalize approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shreyas-s-rao @renormalize @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot