Allow specifying traffic distribution preference for the etcd client Service #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
reviewed/ok-to-test
15 tasks
gardener-robot
added
area/high-availability
seshachalam-yv
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Thank you, @ialidzhikov, for adding support for the TrafficDistribution. Please address the following minor comments.
gardener-robot
added
the
size/m
gardener-robot-ci-2
added
reviewed/ok-to-test
|
@seshachalam-yv , thanks for the suggestions! I addressed them in ca098ad. |
|
@seshachalam-yv Command |
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/area high-availability
/kind enhancement
What this PR does / why we need it:
In Kubernetes, there is a new feature allowing to achieve topology-aware routing for Service endpoints -
ServiceTrafficDistribution.With gardener/gardener#10973, we would like to use the new
ServiceTrafficDistributionfeature starting Kubernetes 1.31+ instead of theTopologyAwareHintsfeature.To keep etcd client Services topology-aware, we need to be able to specify the
.spec.trafficDistributionfield of the client Service via the Etcd resource. This PR makes this possible.Which issue(s) this PR fixes:
Part of gardener/gardener#10421
Special notes for your reviewer:
N/A
Release note: