Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to avoid leader election timeout #232

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Dec 14, 2021

What this PR does / why we need it:
On busy seeds the DNS controller manager loses its lease sporadically because of lease timeout.
To mitigate this behaviour, several changes have been applied:

  • enlarge default minAllow value in VPA from 20m to 50 m CPU
  • longer default lease duration (from 15s to 30s)
  • restrict GOMAXPROCS by importing go.uber.org/automaxprocs
  • using global shared informer for secrets (was not used because of code ordering and namespaced informers have been created instead)

Further future usage, a command line flag --enableProfiling has added to enable the profiling endpoints optionally on the server http port.

Special notes for your reviewer:

Release note:

Improvements to avoid leader election timeout: longer default lease duration, higher CPU minimum

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 14, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 14, 2021
@MartinWeindel MartinWeindel force-pushed the fix/leader-election-timeout branch from f8e3e4d to b7b5917 Compare December 14, 2021 15:34
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2021
@mandelsoft mandelsoft merged commit 5276711 into master Dec 15, 2021
@mandelsoft mandelsoft deleted the fix/leader-election-timeout branch December 15, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants