Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't deploy PSPs for cluster versions >=1.24 #273

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Don't deploy PSPs for cluster versions >=1.24 #273

merged 2 commits into from
Aug 19, 2022

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Aug 19, 2022 •
edited by MartinWeindel
Loading

What this PR does / why we need it:
PodSecurityPolicy is deprecated and will be disabled in kubernetes v1.25+.
The PodSecurityPolicys in the seeds are not currently used in any landscapes.
This PR stops deploying them for clusters >=1.24 so that they can be properly garbage collected.

Which issue(s) this PR fixes:
Part of gardener/gardener#5250

Special notes for your reviewer:

Release note:

The `PodSecurityPolicy` `dns-controller-manager` is not deployed for seeds with k8s `>=1.24`

@shafeeqes shafeeqes requested a review from a team as a code owner August 19, 2022 13:19
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 19, 2022
@shafeeqes
Copy link
Contributor Author

/kind enhancement
/area open-source

@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 19, 2022
@shafeeqes shafeeqes changed the title Don't deploy PSPs for cluster versions >=1.24 Don't deploy PSPs for cluster versions >=1.24 Aug 19, 2022
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension labels Aug 19, 2022
@shafeeqes shafeeqes mentioned this pull request Aug 19, 2022
Closed
23 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 19, 2022
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 19, 2022
@shafeeqes
Copy link
Contributor Author

shafeeqes commented Aug 19, 2022 •
edited
Loading

make generate fails for me.

$ make generate
Generating deepcopy funcs
Generating clientset for dns:v1alpha1 at github.com/gardener/external-dns-management/pkg/client/dns/clientset
Generating listers for dns:v1alpha1 at github.com/gardener/external-dns-management/pkg/client/dns/listers
Generating informers for dns:v1alpha1 at github.com/gardener/external-dns-management/pkg/client/dns/informers
DIR: /Users/i545724/go/src/github.com/gardener/external-dns-management/pkg/apis/dns
CMD: /var/folders/ch/ywsswccj2y3gdlvxvbfwwfjw0000gn/T/go-build2777394492/b001/exe/controller-gen crd:crdVersions=v1 paths=.;./v1alpha1/. output:crd:artifacts:config=crds
Generating deepcopy funcs
Generating clientset for dns:v1alpha1 at github.com/gardener/external-dns-management/pkg/client/dns/clientset
Generating listers for dns:v1alpha1 at github.com/gardener/external-dns-management/pkg/client/dns/listers
Generating informers for dns:v1alpha1 at github.com/gardener/external-dns-management/pkg/client/dns/informers
charts/external-dns-management/doc.go:17: running "../../hack/generate-controller-registration.sh": exit status 1
make: *** [generate] Error 1

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 19, 2022
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 19, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 19, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 19, 2022
MartinWeindel
MartinWeindel approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 19, 2022
@MartinWeindel MartinWeindel merged commit d251d93 into gardener:master Aug 19, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 19, 2022
@shafeeqes shafeeqes deleted the enh/podsecurity branch February 7, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot