-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't deploy PSP
s for cluster versions >=1.24
#273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 19, 2022
/kind enhancement |
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 19, 2022
shafeeqes
changed the title
Don't deploy PSPs for cluster versions >=1.24
Don't deploy Aug 19, 2022
PSP
s for cluster versions >=1.24
gardener-robot
added
needs/review
Needs review
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/enhancement
Enhancement, improvement, extension
labels
Aug 19, 2022
23 tasks
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 19, 2022
shafeeqes
force-pushed
the
enh/podsecurity
branch
from
August 19, 2022 13:57
e4082f2
to
16e6304
Compare
gardener-robot
added
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
and removed
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
Aug 19, 2022
|
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Aug 19, 2022
shafeeqes
force-pushed
the
enh/podsecurity
branch
from
August 19, 2022 14:02
16e6304
to
f00886a
Compare
gardener-robot
added
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
and removed
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
labels
Aug 19, 2022
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 19, 2022
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Aug 19, 2022
MartinWeindel
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
Aug 19, 2022
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PodSecurityPolicy
is deprecated and will be disabled in kubernetesv1.25
+.The
PodSecurityPolicy
s in the seeds are not currently used in any landscapes.This PR stops deploying them for clusters >=1.24 so that they can be properly garbage collected.
Which issue(s) this PR fixes:
Part of gardener/gardener#5250
Special notes for your reviewer:
Release note: