Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag --disable-dnsname-validation #276

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Add flag --disable-dnsname-validation #276

merged 1 commit into from
Aug 29, 2022

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Add flag --disable-dnsname-validation to optionally disable the validation of DNS names according to RFC 1123.

Which issue(s) this PR fixes:
Fixes #272

Release note:

Add flag --disable-dnsname-validation to optionally disable the validation of DNS names according to RFC 1123.

@MartinWeindel MartinWeindel requested a review from a team as a code owner August 26, 2022 11:32
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 26, 2022
mandelsoft
mandelsoft reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@mandelsoft mandelsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

And if so, wouldn't it be better to disable the validation per DNSProvider object?

@MartinWeindel
Copy link
Member Author

Why is this needed?

And if so, wouldn't it be better to disable the validation per DNSProvider object?

That's something requested from the community. We will surely not use this flag for Gardener.
I don't think it's worth the effort to spend more time on it.

@MartinWeindel MartinWeindel merged commit cf3a815 into master Aug 29, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 29, 2022
@MartinWeindel MartinWeindel deleted the disable-dnsname-validation-flag branch August 29, 2022 16:12
@MartinWeindel MartinWeindel mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandelsoft mandelsoft mandelsoft approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure DNS - setting @ entry (apex) is not possible
4 participants
@MartinWeindel @mandelsoft @gardener-robot-ci-1 @gardener-robot