Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use '--kube-version' flag for helm template #1039

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Conversation

Diaphteiros
Copy link
Contributor

@Diaphteiros Diaphteiros commented Mar 16, 2023

What this PR does / why we need it:

The helm template command takes an optional --kube-version flag, where the cluster's kubernetes version can be provided. This allows helm charts to differentiate between different k8s versions by using .Capabilities.KubeVersion.
With this PR, the --kube-version flag is provided to all helm template calls.

Release note:

garden-setup will now provide the cluster's version to `helm template` calls via the `--kube-version` flag. This has a few side effects:
- There is a new component called `k8sversion`. It's a dummy component, which doesn't actually deploy anything, but it fetches each pre-existing cluster's (= base cluster and potential soils) k8s version instead.
- After deployment of the virtual kube-apiserver, the export generation now waits until it is ready, so it can fetch its k8s version.
- ⚠️ Since helm might deploy different manifests for different k8s versions, this change means that the result of `sow deploy` now also depends on the k8s versions of all clusters in `landscape.iaas`.
  - Re-running `sow deploy` after upgrading the base cluster to a higher k8s version could therefore lead to changes.
  - This could be prevented by not re-running the `k8sversion` component, as that one is responsible for fetching the k8s versions. Most of the time, deploying the helm chart fitting to the cluster is probably desired, though.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 16, 2023
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 16, 2023
@Diaphteiros Diaphteiros marked this pull request as ready for review March 16, 2023 16:01
@Diaphteiros Diaphteiros requested a review from a team as a code owner March 16, 2023 16:01
@Diaphteiros Diaphteiros merged commit f623e56 into master Apr 11, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 11, 2023
@Diaphteiros Diaphteiros deleted the capabilities branch April 11, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants