Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trailing plus problem on k8sversion #1203

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix trailing plus problem on k8sversion #1203

merged 1 commit into from
Sep 18, 2023

Conversation

Diaphteiros
Copy link
Contributor

Which issue(s) this PR fixes: #1197

Release note:

Apparently, `kubectl version` returned a minor version with a `+` suffix for some k8s implementations, which garden-setup couldn't handle. The `k8sversion` component, which fetches the cluster versions, now removes this suffix, if it exists.

@Diaphteiros Diaphteiros requested a review from a team as a code owner September 18, 2023 09:04
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 18, 2023
@Diaphteiros Diaphteiros merged commit 2109dc0 into master Sep 18, 2023
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 18, 2023
@Diaphteiros Diaphteiros mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Diaphteiros @gardener-robot