Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable alicloud #771

Merged
merged 28 commits into from
May 24, 2022
Merged

Enable alicloud #771

merged 28 commits into from
May 24, 2022

Conversation

kevin-lacoo
Copy link
Contributor

What this PR does / why we need it:
Support alicloud
Which issue(s) this PR fixes:

Special notes for your reviewer:

Release note:

Support Alicloud

@kevin-lacoo kevin-lacoo requested a review from a team as a code owner May 5, 2022 08:55
@gardener-robot
Copy link

@kevin-lacoo Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 5, 2022
@kevin-lacoo
Copy link
Contributor Author

/hold

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label May 5, 2022
@CLAassistant
Copy link

CLAassistant commented May 5, 2022

CLA assistant check
All committers have signed the CLA.

@kevin-lacoo
Copy link
Contributor Author

/unlock

@gardener-robot
Copy link

@kevin-lacoo Command /unlock is not known.

@kevin-lacoo
Copy link
Contributor Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label May 9, 2022
Copy link
Contributor

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 24, 2022
@Diaphteiros
Copy link
Contributor

Well done, looks great! Thank you!

@Diaphteiros Diaphteiros merged commit a958db4 into gardener:master May 24, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 24, 2022
@Diaphteiros Diaphteiros mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants