Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various fixes #935

Merged
merged 1 commit into from
Nov 30, 2022
Merged

various fixes #935

merged 1 commit into from
Nov 30, 2022

Conversation

Diaphteiros
Copy link
Contributor

@Diaphteiros Diaphteiros commented Nov 21, 2022 •
edited
Loading

What this PR does / why we need it:
Multiple smaller fixes.

Release note:

Fixed a bug which made it impossible to specify some DNS-provider-specific configuration, because the validation expected an int, but the base64-encoding only works on strings.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 21, 2022
@Diaphteiros Diaphteiros marked this pull request as ready for review November 30, 2022 09:21
@Diaphteiros Diaphteiros requested a review from a team as a code owner November 30, 2022 09:21
@Diaphteiros Diaphteiros merged commit 86f617d into master Nov 30, 2022
@Diaphteiros Diaphteiros deleted the fixes branch November 30, 2022 09:23
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Diaphteiros @gardener-robot