Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update seed_manifest for infoblox #968

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

harshcommits
Copy link
Contributor

What this PR does / why we need it:
Update seed_manifest to use Infoblox config

Which issue(s) this PR fixes:
Updated seed manifest config to accept Infoblox config, since base64-encoding requires strings to work

Special notes for your reviewer:

Release note:

fix: update seed_manifest to accept Infoblox config

@harshcommits harshcommits requested a review from a team as a code owner December 20, 2022 02:43
@gardener-robot
Copy link

@harshcommits Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 20, 2022
Copy link
Contributor

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for fixing this.

@Diaphteiros Diaphteiros merged commit 35f295f into gardener:master Jan 11, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants