Set controller-runtime logger #369

petersutter · 2024-01-17T12:00:10Z

What this PR does / why we need it:
If after 30seconds the controller-runtime logger is not set, a warning message and a stacktrace is printed

[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
	>  goroutine 1 [running]:
	>  runtime/debug.Stack()
	>  	/usr/local/go/src/runtime/debug/stack.go:24 +0x64
	>  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
...

This PR initialises the controller-runtime logger

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

holgerkoser

/lgtm

grolu

/lgtm

set controller-runtime logger

222a7bb

petersutter requested a review from a team as a code owner January 17, 2024 12:00

gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 17, 2024

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024

petersutter mentioned this pull request Jan 17, 2024

ssh: List pending nodes #368

Merged

gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 17, 2024

holgerkoser approved these changes Jan 17, 2024

View reviewed changes

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 17, 2024

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024

grolu approved these changes Jan 17, 2024

View reviewed changes

Merge branch 'master' into enh/set-cr-logger

67ba649

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2024

petersutter merged commit a8f4786 into master Jan 17, 2024
8 checks passed

petersutter deleted the enh/set-cr-logger branch January 17, 2024 17:30

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 17, 2024

petersutter added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set controller-runtime logger #369

Set controller-runtime logger #369

petersutter commented Jan 17, 2024

holgerkoser left a comment

grolu left a comment

Set controller-runtime logger #369

Set controller-runtime logger #369

Conversation

petersutter commented Jan 17, 2024

holgerkoser left a comment

Choose a reason for hiding this comment

grolu left a comment

Choose a reason for hiding this comment