Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete workaround #371

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Remove obsolete workaround #371

merged 2 commits into from
Feb 9, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
With gardener/gardener#9056 the workaround to fetch the cluster identity from the shoot is not needed anymore and thus can be removed as every user should then have the permission to fetch the configmap

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/hold until gardener/gardener#9056 is merged and released

Release note:

@petersutter petersutter requested a review from a team as a code owner January 19, 2024 15:12
@gardener-robot gardener-robot added needs/review Needs review reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 19, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 19, 2024
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 19, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2024
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 9, 2024
@petersutter
Copy link
Member Author

/unhold gardener/gardener#9056 is merged and released with gardener/gardener@v1.88.0

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Feb 9, 2024
@petersutter petersutter merged commit 84262c2 into master Feb 9, 2024
8 checks passed
@petersutter petersutter deleted the enh/configuration-doc branch February 9, 2024 13:56
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants