Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] exe file ending should be added for windows builds #372

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[master] exe file ending should be added for windows builds #372

merged 1 commit into from
Jan 23, 2024

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented Jan 22, 2024 •
edited
Loading

What this PR does / why we need it:
exe file ending should be added for windows builds
Bug introduced with #358

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@petersutter petersutter requested a review from a team as a code owner January 22, 2024 10:00
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 22, 2024
grolu
grolu approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2024
@petersutter petersutter merged commit efbd79d into master Jan 23, 2024
8 checks passed
@petersutter petersutter deleted the bug/fix-windows-build branch January 23, 2024 14:17
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 23, 2024
petersutter added a commit that referenced this pull request Jan 23, 2024
@petersutter
exe file ending should be added for windows builds (#372)
a20a3a9 
(cherry picked from commit efbd79d)
@petersutter petersutter changed the title exe file ending should be added for windows builds [master] exe file ending should be added for windows builds Jan 23, 2024
petersutter added a commit that referenced this pull request Jan 23, 2024
@petersutter
exe file ending should be added for windows builds (#372) (#376)
9b120e6 
(cherry picked from commit efbd79d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petersutter @grolu @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot