Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

head-update job should not overwrite component_description trait #466

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
head-update job should not overwrite component_description trait of the base_definition

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@petersutter petersutter requested a review from a team as a code owner October 23, 2024 11:22
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 23, 2024
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 23, 2024
@petersutter petersutter merged commit 0012a7a into master Oct 23, 2024
8 checks passed
@petersutter petersutter deleted the petersutter-patch-1 branch October 23, 2024 11:29
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants