Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autoscaling for node-cpva #131

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

DockToFuture
Copy link
Member

@DockToFuture DockToFuture commented Dec 7, 2021

Co-authored-by: Johannes Scheerer johannes.scheerer@sap.com

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
Set resources.gardener.cloud/preserve-resources=true annotation so that GRM will respect the request values set by node-cpva.

Special notes for your reviewer:

Release note:

Set `resources.gardener.cloud/preserve-resources=true` annotation so that GRM will respect the request values set by `node-cpva`.

Co-authored-by: Johannes Scheerer <johannes.scheerer@sap.com>
@DockToFuture DockToFuture requested review from a team as code owners December 7, 2021 16:01
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 7, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 7, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 7, 2021
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 7, 2021
@DockToFuture DockToFuture merged commit 39d2090 into gardener:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/bug Bug kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants