Drop PodDisruptionBudget
for calico-kube-controllers
#183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind bug
What this PR does / why we need it:
Drop
PodDisruptionBudget
forcalico-kube-controllers
, becausegardener-extension-networking-calico/charts/internal/calico/templates/kube-controller/deployment-calico-kube-controllers.yaml
Lines 14 to 15 in 1e73ca7
calico-kube-controllers
in case it is inCrashLoopBackOff
because of OOM kills.A few references for context:
Which issue(s) this PR fixes:
calico-kube-controllers
was inCrashLoopBackOff
because of OOM kills:Hence, the PDB had
status.disruptionsAllowed=0
:Which caused kube-apiserver to deny the eviction by VPA:
The issue is actually a more general one. However, removing PDBs for singleton pods is the best thing we can do for now to ensure VPA keeps scaling up components on
CrashLoopBackOff
because of OOM kills.Special notes for your reviewer:
Release note: