Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-specified node cidr. #249

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Allow non-specified node cidr. #249

merged 1 commit into from
Mar 15, 2023

Conversation

ScheererJ
Copy link
Member

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
Allow non-specified node cidr.

The changes related to source network address translation unintentionally enforced a specified node cidr. This change relaxes the condition, i.e. node cidr is optional again.
The tests have been refactored to make it easier to add new variants without node cidr specified.

Which issue(s) this PR fixes:
None.

Special notes for your reviewer:

Release note:

Calico extension does not crash anymore when node cidr is not specified.

@ScheererJ
Allow non-specified node cidr.
9e3f21b 
The changes related to source network address translation unintentionally enforced
a specified node cidr. This change relaxes the condition, i.e. node cidr is optional
again.
The tests have been refactored to make it easier to add new variants without node cidr
specified.
@ScheererJ ScheererJ requested review from a team as code owners March 15, 2023 12:33
@gardener-robot gardener-robot added area/networking Networking related kind/bug Bug labels Mar 15, 2023
@gardener-robot
Copy link

@ScheererJ Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 15, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 15, 2023
@axel7born
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 15, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2023
DockToFuture
DockToFuture approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ScheererJ ScheererJ merged commit 11718b6 into gardener:master Mar 15, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DockToFuture DockToFuture DockToFuture approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScheererJ @gardener-robot @axel7born @DockToFuture @gardener-robot-ci-2