Fix mutating web hook for node-local-dns to work with non-default ports. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case a non-default port, i.e. not port 8080, was used the specification of the liveness probe and the exposed health check port may not fit after the mutating web hook for node-local-dns has been applied. This should be fixed now for the standard case. (Port 8080 was not a good choice for a host port and therefore it was changed.)
gardener-robot-ci-2
added
reviewed/ok-to-test
|
@ScheererJ Thank you for your contribution. |
gardener-robot
added
needs/review
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind bug
What this PR does / why we need it:
Fix mutating web hook for node-local-dns to work with non-default ports.
In case a non-default port, i.e. not port 8080, was used the specification
of the liveness probe and the exposed health check port may not fit after
the mutating web hook for node-local-dns has been applied. This should be
fixed now for the standard case.
(Port 8080 was not a good choice for a host port and therefore it was
changed.)
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
With gardener/gardener#6477 the default health check port was changed. Hence, the port needs to be kept by the mutating web hook.
Release note: