Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use buildx to build docker images #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use buildx to build docker images #148

wants to merge 1 commit into from

Conversation

Roncossek
Copy link
Contributor

How to categorize this PR?

/area os
/kind technical-debt

What this PR does / why we need it:

Changes the Makefile to use docker buildx to build container images for this extensions so that we can build images for multiple architectures with linux/amd64 being the default.

Release note:

Container images for the coreos extension are now built with Docker buildx to enable cross-platform builds and default to the `linux/amd64` architecture.

@gardener-robot gardener-robot added area/os Operation system related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 29, 2024
MrBatschner
MrBatschner approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@MrBatschner MrBatschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/add reviewed/ok-to-test

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Nov 29, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrBatschner MrBatschner MrBatschner approved these changes

@dergeberl dergeberl Awaiting requested review from dergeberl dergeberl is a code owner

@timebertt timebertt Awaiting requested review from timebertt timebertt is a code owner

Assignees
No one assigned
Labels
area/os Operation system related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Roncossek @MrBatschner @gardener-robot @ci-shared-oss-pipeline-0