Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for configuring cgroup v1/cgroupfs as a cgroup driver for containerd and kubelet #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrBatschner
Copy link
Contributor

@MrBatschner MrBatschner commented Apr 16, 2024

How to categorize this PR?

/area os
/kind enhancement
/kind bug
/os garden-linux

What this PR does / why we need it:

Garden Linux since 934 supports cgroup v2. Since then, the Garden Linux extension contained code to determine the cgroup hierarchy of the underlying host and configure containerd and kubelet to use cgroupfs as a cgroup driver if the host os uses cgroup v1 and configure them to use systemd as a cgroup driver if the host os uses cgroup v2.
Unfortunately, this cause some issues (#141) in the past.

Since Garden Linux 576 (the last Garden Linux version with cgroup v1) is no longer supported and all future Garden Linux versions will use cgroup v2, with this PR, containerd and kubelet will always be configured to use systemd as cgroup driver - code that would configure either to use cgroupfs is removed.

Note: this extension will require Garden Linux 934 and above is no longer compatible with Garden Linux 576 or lower.

Which issue(s) this PR fixes:
Fixes #141

Release note:

Support for cgroup v1 is removed from the Garden Linux extension, containerd and kubelet will always get configured to use `systemd` as a cgroup driver. With this change, the extension is compatible with Garden Linux 934 or newer only.

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 16, 2024
@gardener-robot gardener-robot added area/os Operation system related kind/bug Bug kind/enhancement Enhancement, improvement, extension os/garden-linux Related to Garden Linux OS needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 16, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 16, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 7, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 7, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 7, 2024
@MrBatschner
Copy link
Contributor Author

/ready

@gardener-robot gardener-robot marked this pull request as ready for review May 8, 2024 15:10
@gardener-robot gardener-robot requested review from a team as code owners May 8, 2024 15:10
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/os Operation system related kind/bug Bug kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else os/garden-linux Related to Garden Linux OS size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing nodes get cgroup driver configured inconsistently on extension upgrade to 0.23.0
5 participants