Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace packr with golang's native embed package #30

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Replace packr with golang's native embed package #30

merged 2 commits into from
Apr 26, 2021

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind cleanup
/os garden-linux

What this PR does / why we need it:

  • gardener revendoring at v1.21.0
  • Upgrades go version to v1.16
  • replaces packr2 with native embed package.

SInce the test framework from g/g depends on packr, the dependency cannot be completely eliminated for now, but it is only used on tests.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kon-angelo kon-angelo requested a review from a team as a code owner April 22, 2021 12:17
@gardener-robot gardener-robot added area/control-plane Control plane related kind/cleanup Something that is not needed anymore and can be cleaned up os/garden-linux Related to Garden Linux OS needs/review Needs review labels Apr 22, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Apr 22, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 22, 2021
@kon-angelo
Copy link
Contributor Author

It fails for now because refs/meta/ci is using golang v1.15.8 docker image.

rfranzke
rfranzke reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/invite @vpnachev

Dockerfile Show resolved Hide resolved
pkg/generator/testfiles/embed.go Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2021
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 26, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 26, 2021
rfranzke
rfranzke approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 26, 2021
@rfranzke rfranzke merged commit cb4cbfc into gardener:master Apr 26, 2021
LucaBernstein pushed a commit to LucaBernstein/gardener-extension-os-gardenlinux that referenced this pull request Jun 5, 2024
@rfranzke
Merge pull request gardener#30 from vpnachev/update-golang-alpine
4963f0f 
Update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@vpnachev vpnachev Awaiting requested review from vpnachev

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/garden-linux Related to Garden Linux OS reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kon-angelo @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot