Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener/gardener@v1.40.2 #442

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Vendor gardener/gardener@v1.40.2 #442

merged 4 commits into from
Feb 24, 2022

Conversation

jia-jerry
Copy link
Contributor

@jia-jerry jia-jerry commented Feb 23, 2022 •
edited by ialidzhikov
Loading

How to categorize this PR?

/kind bug
/platform alicloud

What this PR does / why we need it:
Regular vendor g/g and fix some critical issues like gardener/gardener#5474
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Kubernetes v1.15 and v1.16 are no longer supported by the extension.

@jia-jerry jia-jerry requested review from a team as code owners February 23, 2022 09:11
@gardener-robot gardener-robot added kind/bug Bug platform/alicloud Alicloud platform/infrastructure needs/review Needs review labels Feb 23, 2022
@jia-jerry jia-jerry added this to the v1.33 milestone Feb 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2022
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Feb 23, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2022
rfranzke
rfranzke previously approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 23, 2022
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Feb 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2022
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Feb 23, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2022
@jia-jerry
Copy link
Contributor Author

/help

@gardener-robot
Copy link

@jia-jerry Here my list of commands:

Man Page
Synopsis What & Who Description & Examples
/assign [@user...] Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Commenter		 Assign given people (or yourself if none specified) to issue or PR. Commenters may only assign themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /assign
- /assign @johndoe @janedoe
- /assign platform/bare-metal
/unassign [@user...] Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Commenter		 Unassign given people (or yourself if none specified) from issue or PR. Commenters may only unassign themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /unassign
- /unassign @johndoe @janedoe
- /unassign platform/bare-metal
/cla Valid for
PullRequest
Permitted for
Anyone		 Recheck Contributor License Agreement (CLA) for PR.
Examples:
- /cla
/diag Valid for
Issue
Permitted for
Member,
Author,
Commenter		 Run diagnosis on shoot cluster. Can only be invoked with a shoot cluster dashboard link as argument or for shoot cluster issues with a dashboard link in the body and labeled with topology/shoot. Can only be invoked by Gardener staff, shoot cluster project members, or issue authors.
Examples:
- /diag
/duplicate Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author		 Mark issue or PR as duplicate of another one. The referenced issue/PR may be in the same repo (e.g. #123 or GH-123), on the same server (e.g. org/repo#123), or even on another server (e.g. https://server/org/repo/issues/123). Author, assignees, and code owners of the referenced issue/PR will be informed about this duplicate. Information will be redacted if this duplicate is private and the referenced one is public. An attempt to reference a private issue/PR from public will be rejected.
Examples:
- /duplicate
/help Valid for
Issue,
PullRequest
Permitted for
Anyone		 Get help on all available commands.
Examples:
- /help
Synonyms: /help, /hi, /hello, /hola, /hallo, /rtfm
/add label... Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author		 Add label to issue or PR (default if no command is recognized). Authors may only add certain white-listed labels such as kind/*, priority/*, area/*, component/*, os/*, platform/*. The labels can be either fully qualified like kind/bug, just the identifier like bug, or starting with the category like kind followed by one or many identifiers in that category.
Examples:
- /add area/cost component/gardener
- /add cost gardener
- /add kind bug regression
- /area/cost component/gardener
- /cost gardener
- /kind bug regression
Synonyms: /add, /set, /label, /start, /begin
/remove label... Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author		 Remove label from issue or PR. Authors may only remove certain white-listed labels such as kind/*, priority/*, area/*, component/*, os/*, platform/*. The labels can be either fully qualified like kind/bug, just the identifier like bug, or starting with the category like kind followed by one or many identifiers in that category.
Examples:
- /remove area/cost component/gardener
- /remove cost gardener
- /remove kind bug regression
Synonyms: /remove, /rem, /unset, /unlabel, /stop, /end, /del, /drop, /cancel
/lgtm Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member		 Add reviewed/lgtm label to issue or PR (and remove conflicting labels).
Examples:
- /lgtm
/hold Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author		 Add reviewed/do-not-merge label to issue or PR (and remove conflicting labels).
Examples:
- /hold
/unhold Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author		 Remove reviewed/do-not-merge label from issue or PR.
Examples:
- /unhold
/close Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author,
Owner		 Close issue or PR.
Examples:
- /close
/reopen Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author,
Owner		 Reopen issue or PR.
Examples:
- /reopen
Synonyms: /reopen, /open
/touch Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author,
Owner		 Remove lifecycle/icebox, stale, or rotten label from issue or PR. Authors may only remove the stale or rotten labels.
Examples:
- /touch
/plan milestone Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member		 Set milestone for issue/PR.
Examples:
- /plan 2030-Q1
Synonyms: /plan, /schedule, /milestone
/unplan Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member		 Unset milestone for issue.
Examples:
- /unplan
Synonyms: /unplan, /unschedule, /unmilestone
/ping [@user...] [msg] Valid for
Issue,
PullRequest
Permitted for
Anyone		 Ping people (or just in general if none specified) with a message to take a look at issue or PR (like /honk in prow). Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /ping
- /ping @johndoe @janedoe Have you checked?
- /ping platform/bare-metal Any Progress?
Synonyms: /ping, /honk
/ready-for-review Valid for
PullRequest
Permitted for
Maintainer,
Member,
Author		 Turn draft PR into ready for review PR.
Examples:
- /ready-for-review
Synonyms: /ready-for-review, /ready
/invite [@user...] Valid for
PullRequest
Permitted for
Maintainer,
Member,
Author,
Commenter		 Request PR review from given people (or yourself if none specified) for PR. Commenters may only invite themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /invite
- /invite @johndoe @janedoe
- /invite platform/bare-metal
Synonyms: /invite, /review
/uninvite [@user...] Valid for
PullRequest
Permitted for
Maintainer,
Member,
Commenter		 No longer request PR review from given people (or yourself if none specified) for PR. Commenters may only uninvite themselves. Labels can be used as well, which are subsituted with the registered reviewers for that label.
Examples:
- /uninvite
- /uninvite @johndoe @janedoe
- /uninvite platform/bare-metal
Synonyms: /uninvite, /unreview
/title title Valid for
Issue,
PullRequest
Permitted for
Maintainer,
Member,
Author		 Change title of issue or PR.
Examples:
- /title Add metrics endpoint
Synonyms: /title, /retitle

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2022
@dkistner
Copy link
Member

Are you not going to adapt to use ginkgo@v2?

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2022
@jia-jerry
Copy link
Contributor Author

Are you not going to adapt to use ginkgo@v2?

Will open another PR to adopt it.

rfranzke
rfranzke reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update https://github.com/gardener/gardener-extension-provider-alicloud/#supported-kubernetes-versions as well?

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 24, 2022
@jia-jerry
Copy link
Contributor Author

Can you update https://github.com/gardener/gardener-extension-provider-alicloud/#supported-kubernetes-versions as well?

done.

rfranzke
rfranzke reviewed Feb 24, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 24, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 24, 2022
@jia-jerry jia-jerry merged commit ba6c2b7 into master Feb 24, 2022
@jia-jerry jia-jerry deleted the vender_gg_1.40.2 branch February 24, 2022 09:04
@ialidzhikov ialidzhikov mentioned this pull request Jul 15, 2022
Closed
2 tasks
@ialidzhikov ialidzhikov mentioned this pull request Sep 2, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/alicloud Alicloud platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
7 participants
@jia-jerry @gardener-robot @dkistner @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3