Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener@1.65.0 and Upgrade k8s dependencies and controller-runtime #565

Merged
merged 14 commits into from
Mar 3, 2023
Merged

Vendor gardener@1.65.0 and Upgrade k8s dependencies and controller-runtime #565

merged 14 commits into from
Mar 3, 2023

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Feb 7, 2023 •
edited
Loading

How to categorize this PR?

/area open-source
/kind enhancement
/platform alicloud

What this PR does / why we need it:
Vendor gardener v1.65.0
Upgrade k8s dependencies and controller-runtime.

Which issue(s) this PR fixes:

Special notes for your reviewer:
The PR currently vendors gardener master (8d53342ddcf0112209ce85662d7ba6bbcf2890aa).
We need to vendor gardener@1.64.0 once it's released. Hence the PR is in draft.

Release note:

The following dependency is updated:
- github.com/gardener/gardener: v1.62.0 -> v1.65.0
- k8s.io/* : v0.25.2 -> v0.26.1
- sigs.k8s.io/controller-runtime: v0.13.0-> v0.14.4

@shafeeqes shafeeqes requested review from a team as code owners February 7, 2023 07:09
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Feb 7, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 7, 2023
@shafeeqes shafeeqes mentioned this pull request Feb 7, 2023
Closed
20 tasks
@shafeeqes shafeeqes marked this pull request as draft February 7, 2023 07:10
@shafeeqes
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Feb 7, 2023 •
edited
Loading

Testrun: e2e-bjtvb
Workflow: e2e-bjtvb-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Failed    | 54m6s    |
| bastion-test        | bastion-test        | Succeeded | 10m12s   |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 7, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 7, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 7, 2023
@shafeeqes shafeeqes marked this pull request as ready for review February 15, 2023 03:52
@shafeeqes
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Feb 15, 2023 •
edited
Loading

Testrun: e2e-v72vl
Workflow: e2e-v72vl-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 12m26s   |
| bastion-test        | bastion-test        | Succeeded | 8m50s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 15, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 15, 2023
@shafeeqes
Use sets.Set[string] instead of deprecated sets.String
2b56397
@shafeeqes
Replace ioutil.ReadFile with os.ReadFile
30481e7
@shafeeqes
Vendor gardener@v1.64.0
87ecb30 
Upgrade `controller-runtime` dependencies to `v0.14.4`
Remove no longer needed replace directives
@shafeeqes
Adapt imagevector.Read function
bcb7aa9
@shafeeqes
Run make generate
9c0da17
@shafeeqes
Vendor gardener@v1.65.0
cc166ba
@shafeeqes
Remove MR health check for ShootSystemComponentsHealthy condition
34782be 
Gardener now checks all the ManagedResources in the shoot controlplane which does not specify `spec.class`, so these MRs are already covered.
@shafeeqes shafeeqes changed the title Vendor gardener@1.64.0 and Upgrade k8s dependencies and controller-runtime Vendor gardener@1.65.0 and Upgrade k8s dependencies and controller-runtime Feb 28, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 28, 2023
@shafeeqes
Copy link
Contributor Author

/invite @shaoyongfeng @EmoinLanyu @jia-jerry

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 28, 2023
@shafeeqes shafeeqes mentioned this pull request Feb 28, 2023
Closed
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 28, 2023
@shaoyongfeng shaoyongfeng merged commit e49d4e0 into gardener:master Mar 3, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 3, 2023
@shafeeqes shafeeqes deleted the vendor/gardener@1.64 branch March 3, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

@EmoinLanyu EmoinLanyu Awaiting requested review from EmoinLanyu

@jia-jerry jia-jerry Awaiting requested review from jia-jerry

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/alicloud Alicloud platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @shaoyongfeng @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot