-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt NetworkPolicy
s according to recent refactorings
#581
Merged
shaoyongfeng
merged 12 commits into
gardener:master
from
ScheererJ:enhancement/network-policies
Mar 14, 2023
Merged
Adapt NetworkPolicy
s according to recent refactorings
#581
shaoyongfeng
merged 12 commits into
gardener:master
from
ScheererJ:enhancement/network-policies
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/dev-productivity
Developer productivity related (how to improve development)
area/networking
Networking related
area/ops-productivity
Operator productivity related (how to improve operations)
area/security
Security related
kind/enhancement
Enhancement, improvement, extension
platform/alicloud
Alicloud platform/infrastructure
labels
Mar 3, 2023
@ScheererJ Thank you for your contribution. |
gardener-robot
added
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Mar 3, 2023
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Mar 3, 2023
47 tasks
/assign |
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Mar 3, 2023
This is needed for the health check of the `Worker` resource.
ScheererJ
force-pushed
the
enhancement/network-policies
branch
from
March 10, 2023 14:01
5e0e689
to
c3456f0
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Mar 10, 2023
rfranzke
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @jia-jerry @EmoinLanyu @shaoyongfeng
Can we go ahead and merge this PR?
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
Mar 13, 2023
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Mar 13, 2023
...d-controlplane/charts/csi-alicloud/templates/csi-snapshot-validation-webhook-deployment.yaml
Show resolved
Hide resolved
...ontrolplane/charts/csi-alicloud/templates/csi-snapshot-validation-webhook-networkpolicy.yaml
Show resolved
Hide resolved
shaoyongfeng
approved these changes
Mar 14, 2023
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dev-productivity
Developer productivity related (how to improve development)
area/networking
Networking related
area/ops-productivity
Operator productivity related (how to improve operations)
area/security
Security related
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
platform/alicloud
Alicloud platform/infrastructure
reviewed/lgtm
Has approval for merging
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity ops-productivity networking security
/kind enhancement
/platform alicloud
What this PR does / why we need it:
This PR adapts the
NetworkPolicy
s according to the recent refactorings ingardener/gardener
See also gardener/gardener#7589 and https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#networkpolicy-controller.
Which issue(s) this PR fixes:
Part of gardener/gardener#7352
Special notes for your reviewer:
/cc @rfranzke @oliver-goetz @timuthy
Depends on
gardener/gardener@v1.66
to create the expected network policies in the extension namespace.Release note: