Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt NetworkPolicys according to recent refactorings #581

Merged
merged 12 commits into from
Mar 14, 2023
Merged

Adapt NetworkPolicys according to recent refactorings #581

merged 12 commits into from
Mar 14, 2023

Conversation

ScheererJ
Copy link
Member

@ScheererJ ScheererJ commented Mar 3, 2023 •
edited
Loading

How to categorize this PR?

/area dev-productivity ops-productivity networking security
/kind enhancement
/platform alicloud

What this PR does / why we need it:
This PR adapts the NetworkPolicys according to the recent refactorings in gardener/gardener
See also gardener/gardener#7589 and https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#networkpolicy-controller.

Which issue(s) this PR fixes:
Part of gardener/gardener#7352

Special notes for your reviewer:
/cc @rfranzke @oliver-goetz @timuthy

Depends on gardener/gardener@v1.66 to create the expected network policies in the extension namespace.

Release note:

Adapted extension components to support the [FullNetworkPoliciesInRuntimeCluster](https://github.com/gardener/gardener/blob/master/docs/deployment/feature_gates.md#list-of-feature-gates) feature gate introduced by `gardener/gardener` v1.66, see [here](https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#networkpolicy-controller) and [#7352](https://github.com/gardener/gardener/pull/7589) for more information.

@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/networking Networking related area/ops-productivity Operator productivity related (how to improve operations) area/security Security related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure labels Mar 3, 2023
@gardener-robot
Copy link

@ScheererJ Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 3, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 3, 2023
@rfranzke rfranzke mentioned this pull request Mar 3, 2023
Closed
47 tasks
@rfranzke
Copy link
Member

rfranzke commented Mar 3, 2023

/assign

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 3, 2023
@ScheererJ ScheererJ force-pushed the enhancement/network-policies branch from 5e0e689 to c3456f0 Compare March 10, 2023 14:01
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 10, 2023
@ScheererJ ScheererJ marked this pull request as ready for review March 10, 2023 14:03
@ScheererJ ScheererJ requested review from a team as code owners March 10, 2023 14:03
rfranzke
rfranzke approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @jia-jerry @EmoinLanyu @shaoyongfeng
Can we go ahead and merge this PR?

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 13, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 13, 2023
@shaoyongfeng shaoyongfeng merged commit 62c8f28 into gardener:master Mar 14, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 14, 2023
@istvanballok istvanballok mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

Assignees

@rfranzke rfranzke

Labels
area/dev-productivity Developer productivity related (how to improve development) area/networking Networking related area/ops-productivity Operator productivity related (how to improve operations) area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/alicloud Alicloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ScheererJ @gardener-robot @rfranzke @shaoyongfeng @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3