Add ipv6 support. #1024

axel7born · 2024-08-05T15:16:04Z

How to categorize this PR?

/area networking
/kind enhancement
/platform aws

What this PR does / why we need it:
The PR adds required infrastructure changes to deploy IPv6 shoots.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add ipv6 support to deploy IPv6 shoots.

pkg/controller/controlplane/valuesprovider.go

pkg/controller/infrastructure/infraflow/reconcile.go

kon-angelo · 2024-09-02T11:40:17Z

pkg/controller/infrastructure/infraflow/reconcile.go

-	desired.CidrBlock = *c.config.Networks.VPC.CIDR
+
+	if !isIPv4(c.ipFamilies) && c.config.Networks.VPC.CIDR == nil {
+		desired.CidrBlock = "10.0.0.0/16"


I think I forgot the outcome of that discussion around this hardcoded IP and it would be nice if here or better in a comment write something about it.

Probably, it is better not to automatically assign an IPv4 address here and leave that to the user?

Though, I need to adapt the validation.

kon-angelo · 2024-09-02T11:46:10Z

pkg/controller/infrastructure/infraflow/reconcile.go

+				AssignIpv6AddressOnCreation: ptr.To(isIPv6(c.ipFamilies)),
+				CidrBlock: func(cidr string) string {
+					if cidr == "" {
+						return "10.0.32.0/20"


also here regarding the "magic IP"

Same as above, it is probably better to let the user configure the CIDR for the public range.

kon-angelo · 2024-09-02T11:48:01Z

/needs rebase

hebelsan · 2024-09-02T10:52:53Z

pkg/aws/client/client.go

@@ -1202,6 +1206,79 @@ func (c *Client) DeleteInternetGateway(ctx context.Context, id string) error {
 	return ignoreNotFound(err)
 }

+func (c *Client) CreateEgressOnlyInternetGateway(ctx context.Context, gateway *EgressOnlyInternetGateway) (*EgressOnlyInternetGateway, error) {


Public func CreateEgressOnlyInternetGateway should have a describing comment

I added a comment.

hebelsan · 2024-09-02T11:53:37Z

pkg/controller/infrastructure/actuator_reconcile.go

@@ -395,6 +407,18 @@ func generateTerraformInfraConfig(ctx context.Context, infrastructure *extension
 		dhcpDomainName = fmt.Sprintf("%s.compute.internal", infrastructure.Spec.Region)
 	}

+	isIPv4 := true
+	isIPv6 := false
+	if sets.New[v1beta1.IPFamily](ipFamilies...).Has(v1beta1.IPFamilyIPv6) {


Is there a special reason why we use sets, couldn't we just use slices.Contains() here?

No special reason, I changed it to slices.Contains().

kon-angelo · 2024-10-08T07:23:01Z

/test

testmachinery · 2024-10-08T07:23:05Z

Testrun: e2e-f7zd9
Workflow: e2e-f7zd9-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-migrate | Failed    | 22m30s   |
| infrastructure-test | infrastructure-test-recover | Failed    | 23m14s   |
| bastion-test        | bastion-test                | Succeeded | 9m0s     |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m14s    |
| infrastructure-test | infrastructure-test-tf      | Failed    | 35m9s    |
| infrastructure-test | infrastructure-test-flow    | Succeeded | 26m43s   |
+---------------------+-----------------------------+-----------+----------+

IPv6 addresses of subnets were different for terraform and flow. This resulted in a subnet changes after migration.

kon-angelo · 2024-10-09T06:29:02Z

/test

testmachinery · 2024-10-09T06:29:05Z

Testrun: e2e-85nst
Workflow: e2e-85nst-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-recover | Failed    | 25m27s   |
| bastion-test        | bastion-test                | Succeeded | 8m43s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m8s     |
| infrastructure-test | infrastructure-test-tf      | Failed    | 23m52s   |
| infrastructure-test | infrastructure-test-flow    | Failed    | 26m35s   |
| infrastructure-test | infrastructure-test-migrate | Failed    | 20m59s   |
+---------------------+-----------------------------+-----------+----------+

DockToFuture · 2024-10-09T07:39:08Z

/retest

ScheererJ · 2024-10-09T08:27:34Z

/test

testmachinery · 2024-10-09T08:27:37Z

Testrun: e2e-vlt45
Workflow: e2e-vlt45-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m13s    |
| infrastructure-test | infrastructure-test-tf      | Failed    | 24m0s    |
| infrastructure-test | infrastructure-test-flow    | Failed    | 23m13s   |
| infrastructure-test | infrastructure-test-migrate | Failed    | 24m54s   |
| infrastructure-test | infrastructure-test-recover | Succeeded | 27m51s   |
| bastion-test        | bastion-test                | Succeeded | 9m42s    |
+---------------------+-----------------------------+-----------+----------+

kon-angelo · 2024-10-09T09:40:26Z

/test

testmachinery · 2024-10-09T09:40:30Z

Testrun: e2e-sqqbf
Workflow: e2e-sqqbf-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| dnsrecord-test      | dnsrecord-test              | Succeeded | 5m50s    |
| infrastructure-test | infrastructure-test-tf      | Failed    | 31m41s   |
| infrastructure-test | infrastructure-test-flow    | Failed    | 26m23s   |
| infrastructure-test | infrastructure-test-migrate | Failed    | 30m27s   |
| infrastructure-test | infrastructure-test-recover | Failed    | 23m48s   |
| bastion-test        | bastion-test                | Succeeded | 8m37s    |
+---------------------+-----------------------------+-----------+----------+

kon-angelo · 2024-10-09T12:17:40Z

/test

testmachinery · 2024-10-09T12:17:44Z

Testrun: e2e-2lxwq
Workflow: e2e-2lxwq-wf
Phase: Succeeded

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-tf      | Succeeded | 34m17s   |
| infrastructure-test | infrastructure-test-flow    | Succeeded | 26m7s    |
| infrastructure-test | infrastructure-test-migrate | Succeeded | 30m4s    |
| infrastructure-test | infrastructure-test-recover | Succeeded | 27m25s   |
| bastion-test        | bastion-test                | Succeeded | 4m36s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 5m53s    |
+---------------------+-----------------------------+-----------+----------+

kon-angelo

/lgtm

axel7born requested review from a team as code owners August 5, 2024 15:16

gardener-robot added the needs/review Needs review label Aug 5, 2024

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 5, 2024

gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 5, 2024

axel7born mentioned this pull request Aug 5, 2024

Set ipv6AddressCount and ipv6PrefixCount when dualstack is enabled. #785

Closed

kon-angelo reviewed Sep 2, 2024

View reviewed changes

gardener-robot added the needs/rebase Needs git rebase label Sep 2, 2024

hebelsan reviewed Sep 2, 2024

View reviewed changes

axel7born force-pushed the add-ipv6 branch from 0baa71d to 0cf707f Compare September 10, 2024 15:00

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 10, 2024

axel7born force-pushed the add-ipv6 branch from 0cf707f to 6817edf Compare September 11, 2024 07:43

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 11, 2024

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 13, 2024

axel7born force-pushed the add-ipv6 branch from a33a944 to 81dce2e Compare September 14, 2024 16:22

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2024

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2024

axel7born force-pushed the add-ipv6 branch from 9af2acd to b599b86 Compare September 19, 2024 12:52

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 8, 2024

Fix integration test.

9eb90bd

IPv6 addresses of subnets were different for terraform and flow. This resulted in a subnet changes after migration.

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 9, 2024

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 9, 2024

Check the eogw that belongs to the vpc.

87cd37d

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 9, 2024

kon-angelo approved these changes Oct 9, 2024

View reviewed changes

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 9, 2024

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 9, 2024

AndreasBurger approved these changes Oct 9, 2024

View reviewed changes

kon-angelo merged commit 8975d72 into gardener:master Oct 9, 2024
17 checks passed

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 9, 2024

ScheererJ mentioned this pull request Oct 10, 2024

Support IPv6 gardener/gardener#8899

Open

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ipv6 support. #1024

Add ipv6 support. #1024

axel7born commented Aug 5, 2024

kon-angelo Sep 2, 2024

axel7born Sep 11, 2024

axel7born Sep 11, 2024

kon-angelo Sep 2, 2024

axel7born Sep 11, 2024

kon-angelo commented Sep 2, 2024

hebelsan Sep 2, 2024

axel7born Sep 11, 2024

hebelsan Sep 2, 2024

axel7born Sep 11, 2024

kon-angelo commented Oct 8, 2024

testmachinery bot commented Oct 8, 2024 •

edited

Loading

kon-angelo commented Oct 9, 2024

testmachinery bot commented Oct 9, 2024 •

edited

Loading

DockToFuture commented Oct 9, 2024

ScheererJ commented Oct 9, 2024

testmachinery bot commented Oct 9, 2024 •

edited

Loading

kon-angelo commented Oct 9, 2024

testmachinery bot commented Oct 9, 2024 •

edited

Loading

kon-angelo commented Oct 9, 2024

testmachinery bot commented Oct 9, 2024 •

edited

Loading

kon-angelo left a comment

Add ipv6 support. #1024

Add ipv6 support. #1024

Conversation

axel7born commented Aug 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kon-angelo commented Sep 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kon-angelo commented Oct 8, 2024

testmachinery bot commented Oct 8, 2024 • edited Loading

kon-angelo commented Oct 9, 2024

testmachinery bot commented Oct 9, 2024 • edited Loading

DockToFuture commented Oct 9, 2024

ScheererJ commented Oct 9, 2024

testmachinery bot commented Oct 9, 2024 • edited Loading

kon-angelo commented Oct 9, 2024

testmachinery bot commented Oct 9, 2024 • edited Loading

kon-angelo commented Oct 9, 2024

testmachinery bot commented Oct 9, 2024 • edited Loading

kon-angelo left a comment

Choose a reason for hiding this comment

testmachinery bot commented Oct 8, 2024 •

edited

Loading

testmachinery bot commented Oct 9, 2024 •

edited

Loading

testmachinery bot commented Oct 9, 2024 •

edited

Loading

testmachinery bot commented Oct 9, 2024 •

edited

Loading

testmachinery bot commented Oct 9, 2024 •

edited

Loading