Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-27] Use cloud profile bastion machine and image #1040

Merged
merged 6 commits into from
Nov 14, 2024
Merged

[GEP-27] Use cloud profile bastion machine and image #1040

merged 6 commits into from
Nov 14, 2024

Conversation

hebelsan
Copy link
Contributor

How to categorize this PR?

/area quality
/kind enhancement
/platform aws

What this PR does / why we need it:
Instead of using a hardcoded bastion image we will use the image provided in the bastion section of the cloud profile.
See also gardener/gardener#9935

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
We need to wait until the bastion section is released with gardener/gardener/types_cloudprofile.go.

Release note:

Create bastion vm from the info provided in the cloud profile bastion section

@hebelsan hebelsan requested review from a team as code owners August 29, 2024 09:37
@gardener-robot gardener-robot added needs/review Needs review area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure labels Aug 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 29, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Aug 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 29, 2024
@hebelsan
Copy link
Contributor Author

/hold until updated gardener/gardener

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 3, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 3, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 17, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Oct 15, 2024
@gardener-robot
Copy link

@hebelsan You need rebase this pull request with latest master branch. Please check.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 31, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 31, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 31, 2024
@hebelsan
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Oct 31, 2024 •
edited
Loading

Testrun: e2e-2d5vn
Workflow: e2e-2d5vn-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-migrate | Succeeded | 31m35s   |
| infrastructure-test | infrastructure-test-recover | Succeeded | 28m4s    |
| bastion-test        | bastion-test                | Succeeded | 6m16s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m42s    |
| infrastructure-test | infrastructure-test-tf      | Failed    | 34m19s   |
| infrastructure-test | infrastructure-test-flow    | Succeeded | 28m11s   |
+---------------------+-----------------------------+-----------+----------+

@hebelsan
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Oct 31, 2024 •
edited
Loading

Testrun: e2e-v44g6
Workflow: e2e-v44g6-wf
Phase: Succeeded

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-recover | Succeeded | 28m26s   |
| bastion-test        | bastion-test                | Succeeded | 6m6s     |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m37s    |
| infrastructure-test | infrastructure-test-tf      | Succeeded | 36m31s   |
| infrastructure-test | infrastructure-test-flow    | Succeeded | 27m40s   |
| infrastructure-test | infrastructure-test-migrate | Succeeded | 31m20s   |
+---------------------+-----------------------------+-----------+----------+

@hebelsan
Copy link
Contributor Author

hebelsan commented Nov 7, 2024

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 7, 2024
AndreasBurger
AndreasBurger requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

Makefile Outdated
@@ -169,6 +170,7 @@ integration-test-infra:
--secret-access-key='$(shell cat $(SECRET_ACCESS_KEY_FILE))' \
--region=$(REGION) \
--reconciler=$(RECONCILER)
--love-level=$(LOG_LEVEL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not seem correct.

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 14, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 14, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 14, 2024
@hebelsan hebelsan merged commit a63bb0e into gardener:master Nov 14, 2024
10 checks passed
@hebelsan hebelsan deleted the bastion-rework branch November 14, 2024 16:17
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else platform/aws Amazon web services platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hebelsan @gardener-robot @AndreasBurger @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3