Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.57] Automated cherry pick of #1039: fix controlplane migration case for the infrastructure resources #1043

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[release-v1.57] Automated cherry pick of #1039: fix controlplane migration case for the infrastructure resources #1043

merged 1 commit into from
Aug 29, 2024

Conversation

kon-angelo
Copy link
Contributor

/kind bug
/area control-plane-migration

Cherry pick of #1039 on release-v1.57.

#1039: fix controlplane migration case for the infrastructure resources

Release Notes:

Fix an issue where terraformer artifacts would not be deleted during the control-plane-migration `migrate` phase.

@kon-angelo kon-angelo requested review from a team as code owners August 29, 2024 10:44
@gardener-robot gardener-robot added needs/review Needs review area/control-plane-migration Control plane migration related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 29, 2024
hebelsan
hebelsan approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 29, 2024
@AndreasBurger AndreasBurger added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 29, 2024
@AndreasBurger AndreasBurger merged commit aa3ebb9 into gardener:release-v1.57 Aug 29, 2024
20 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/control-plane-migration Control plane migration related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kon-angelo @hebelsan @AndreasBurger @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot