Remove min/maxAllowed #1070
Merged
Remove min/maxAllowed #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot
added
area/control-plane
Comment on lines
9
to
12
| resourcePolicy: | ||
| containerPolicies: | ||
| - containerName: '*' | ||
| minAllowed: | ||
| memory: {{ required ".Values.global.vpa.resourcePolicy.minAllowed.memory is required" .Values.global.vpa.resourcePolicy.minAllowed.memory }} | ||
| controlledValues: RequestsOnly |
There was a problem hiding this comment.
Empty sets are falsy. I am not sure what the actual desired outcome is (@kon-angelo) but with this we get the blanket policy when we configure anything in Values.global.vpa.resourcePolicy and nothing otherwise.
Did not catch that on the original PR :/.
There was a problem hiding this comment.
Agree, we probably want to remove all vpa configs from values.yaml and also remove the check {{- if .Values.global.vpa.resourcePolicy }} in vpa.yaml.
There was a problem hiding this comment.
I agree we need to remove the conditional
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
kon-angelo
reviewed
Sep 30, 2024
Comment on lines
17
to
19
| # resourcePolicy: | ||
| # minAllowed: | ||
| # memory: 64Mi |
There was a problem hiding this comment.
Either remove the block or let it all be a chart value
Comment on lines
17
to
19
| # resourcePolicy: | ||
| # minAllowed: | ||
| # memory: 64Mi |
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform aws
What this PR does / why we need it:
Remove VPA (min|max)Allowed settings.
minAllowed may cause wasted resources while maxAllowed may cause under-reservation and hence noisy neighbor issues.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: