Create IPv6 ServiceCIDR and write IPv6 ranges to Infra.Status.Networking
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
the
platform/aws
|
@axel7born Labels area/todo, kind/todo do not exist. |
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
area/networking
gardener-robot-ci-2
added
needs/ok-to-test
axel7born
force-pushed
the
ipv6-service-cidr-pr
branch
from
28f9410 to
4cc8bda
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
axel7born
force-pushed
the
ipv6-service-cidr-pr
branch
from
4cc8bda to
6ddb1c3
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
axel7born
force-pushed
the
ipv6-service-cidr-pr
branch
from
6ddb1c3 to
60b3046
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
58 tasks
axel7born
force-pushed
the
ipv6-service-cidr-pr
branch
from
60b3046 to
4085b14
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-996mj +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test-recover | Failed | 27m1s | | bastion-test | bastion-test | Succeeded | 8m46s | | dnsrecord-test | dnsrecord-test | Succeeded | 6m9s | | infrastructure-test | infrastructure-test-tf | Succeeded | 35m39s | | infrastructure-test | infrastructure-test-flow | Succeeded | 27m57s | | infrastructure-test | infrastructure-test-migrate | Succeeded | 30m58s | +---------------------+-----------------------------+-----------+----------+ |
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-8dt5q +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test-flow | Succeeded | 27m10s | | bastion-test | bastion-test | Succeeded | 8m48s | | dnsrecord-test | dnsrecord-test | Succeeded | 5m52s | | infrastructure-test | infrastructure-test-tf | Succeeded | 34m22s | | infrastructure-test | infrastructure-test-migrate | Succeeded | 30m44s | | infrastructure-test | infrastructure-test-recover | Succeeded | 25m23s | +---------------------+-----------------------------+-----------+----------+ |
hebelsan
reviewed
Oct 14, 2024
pkg/aws/client/client.go
Outdated
| } | ||
| var cidrs []string | ||
| for _, cidrReservation := range output.SubnetIpv6CidrReservations { | ||
| cidrs = append(cidrs, *cidrReservation.Cidr) |
There was a problem hiding this comment.
Can we be sure that there won't be a nil pointer dereference?
There was a problem hiding this comment.
Actually, It would be weird to get an array containing nil values and a CIDRReservation without a Cidr would also be strange. What should I check for nil? cidrReservation, cidr or both?
There was a problem hiding this comment.
You are right, it would be pretty unusual.
But I think we're better safe than sorry, so I vote for adding a check for both cidrReservation and cidrReservation.Cidr.
Co-authored-by: Alexander Hebel <alexander.hebel@sap.com>
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind enhancement
/platform aws
What this PR does / why we need it:
Create an IPv6 CIDR reservation for the first nodes subnet that we find, use it as Service CIDR and write it to
Infra.Status.Networking.The CIDR of the VPC will be used as Node range and Pod range and written to
Infra.Status.Networking.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: