Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support nat64 and dns64 #1082

Merged
merged 2 commits into from
Oct 14, 2024
Merged

support nat64 and dns64 #1082

merged 2 commits into from
Oct 14, 2024

Conversation

DockToFuture
Copy link
Member

@DockToFuture DockToFuture commented Oct 10, 2024 •
edited
Loading

How to categorize this PR?

/area networking
/kind enhancement
/platform aws

What this PR does / why we need it:
Enable nat64 and dns64 for IPv6 shoot clusters.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Enable `nat64` and `dns64` for IPv6 shoot clusters.

@DockToFuture DockToFuture requested review from a team as code owners October 10, 2024 11:05
@gardener-robot gardener-robot added the needs/review Needs review label Oct 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 10, 2024
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 10, 2024
@DockToFuture DockToFuture mentioned this pull request Oct 10, 2024
Open
58 tasks
@ScheererJ
Copy link
Member

/test

@testmachinery
Copy link

testmachinery bot commented Oct 10, 2024 •
edited
Loading

Testrun: e2e-j8clz
Workflow: e2e-j8clz-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-tf      | Failed    | 33m0s    |
| infrastructure-test | infrastructure-test-flow    | Failed    | 27m29s   |
| infrastructure-test | infrastructure-test-migrate | Failed    | 30m7s    |
| infrastructure-test | infrastructure-test-recover | Failed    | 25m27s   |
| bastion-test        | bastion-test                | Succeeded | 5m54s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 5m58s    |
+---------------------+-----------------------------+-----------+----------+

ScheererJ
ScheererJ previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 10, 2024
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Oct 10, 2024
@ScheererJ
Copy link
Member

/test

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 10, 2024
@testmachinery
Copy link

testmachinery bot commented Oct 10, 2024 •
edited
Loading

Testrun: e2e-rfhtw
Workflow: e2e-rfhtw-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-tf      | Succeeded | 38m31s   |
| infrastructure-test | infrastructure-test-flow    | Failed    | 26m35s   |
| infrastructure-test | infrastructure-test-migrate | Failed    | 35m12s   |
| infrastructure-test | infrastructure-test-recover | Failed    | 38m52s   |
| bastion-test        | bastion-test                | Succeeded | 8m27s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 5m57s    |
+---------------------+-----------------------------+-----------+----------+

@DockToFuture
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Oct 14, 2024 •
edited
Loading

Testrun: e2e-4wx2b
Workflow: e2e-4wx2b-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-recover | Failed    | 36m20s   |
| bastion-test        | bastion-test                | Succeeded | 4m40s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 5m47s    |
| infrastructure-test | infrastructure-test-tf      | Succeeded | 33m20s   |
| infrastructure-test | infrastructure-test-flow    | Failed    | 28m26s   |
| infrastructure-test | infrastructure-test-migrate | Failed    | 29m55s   |
+---------------------+-----------------------------+-----------+----------+

@ScheererJ
Copy link
Member

/test

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 14, 2024
@hebelsan
Copy link
Contributor

/test

@testmachinery
Copy link

testmachinery bot commented Oct 14, 2024 •
edited
Loading

Testrun: e2e-2vd9b
Workflow: e2e-2vd9b-wf
Phase: Succeeded

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-flow    | Succeeded | 26m27s   |
| infrastructure-test | infrastructure-test-migrate | Succeeded | 29m42s   |
| infrastructure-test | infrastructure-test-recover | Succeeded | 26m0s    |
| bastion-test        | bastion-test                | Succeeded | 4m47s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 5m52s    |
| infrastructure-test | infrastructure-test-tf      | Succeeded | 34m45s   |
+---------------------+-----------------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 14, 2024
hebelsan
hebelsan approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kon-angelo kon-angelo merged commit a136b35 into gardener:master Oct 14, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 14, 2024
@DockToFuture DockToFuture deleted the support/dns64nat64 branch October 14, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@hebelsan hebelsan hebelsan approved these changes

@AndreasBurger AndreasBurger AndreasBurger approved these changes

@ScheererJ ScheererJ ScheererJ left review comments

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DockToFuture @ScheererJ @hebelsan @AndreasBurger @kon-angelo @gardener-robot-ci-1 @gardener-robot