Route table duplicate "0.0.0.0/0" rule creation #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-btwqj +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test-recover | Succeeded | 27m15s | | bastion-test | bastion-test | Succeeded | 4m38s | | dnsrecord-test | dnsrecord-test | Succeeded | 5m51s | | infrastructure-test | infrastructure-test-tf | Succeeded | 34m34s | | infrastructure-test | infrastructure-test-flow | Succeeded | 26m21s | | infrastructure-test | infrastructure-test-migrate | Succeeded | 31m7s | +---------------------+-----------------------------+-----------+----------+ |
gardener-robot
added
needs/review
gardener-robot-ci-2
added
needs/ok-to-test
pkg/aws/client/updater.go
Outdated
| if !slices.ContainsFunc(desired.Routes, func(r *Route) bool { | ||
| desiredRouteDestination, err := r.DestinationId() | ||
| if err != nil { | ||
| log.Error(err, "failed to find suitable destination for desired route", "route") |
There was a problem hiding this comment.
This will result in a line like msg="failed to find suitable destination for desired route" error="no route destination found", which is a little bit redundant for my taste.
Maybe something more like
log.Error(err, "error deleting route", "route")Which is not really that much better but does not contain the same information twice.
Also, I think there is an argument missing, don't you mean:
log.Error(err, "failed to find suitable destination for desired route", "route", route)
hebelsan
reviewed
Oct 31, 2024
pkg/aws/client/client.go
Outdated
| @@ -2134,6 +2134,7 @@ func IsNotFoundError(err error) bool { | |||
| // IsAlreadyAssociatedError returns true if the given error is a awserr.Error indicating that an AWS resource was already associated. | |||
| func IsAlreadyAssociatedError(err error) bool { | |||
| if aerr, ok := err.(awserr.Error); ok && aerr.Code() == "Resource.AlreadyAssociated" { | |||
| aerr.Code() | |||
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@AndreasBurger @hebelsan PTAL |
|
/test |
|
Testrun: e2e-76rtb +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test-recover | Succeeded | 26m28s | | bastion-test | bastion-test | Succeeded | 6m36s | | dnsrecord-test | dnsrecord-test | Succeeded | 6m31s | | infrastructure-test | infrastructure-test-tf | Succeeded | 36m12s | | infrastructure-test | infrastructure-test-flow | Succeeded | 27m28s | | infrastructure-test | infrastructure-test-migrate | Succeeded | 31m18s | +---------------------+-----------------------------+-----------+----------+ |
hebelsan
reviewed
Oct 31, 2024
The API for the |
hebelsan
previously approved these changes
Oct 31, 2024
gardener-robot-ci-1
added
the
reviewed/ok-to-test
AndreasBurger
approved these changes
Oct 31, 2024
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
/platform aws
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: