Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bastion infra test #142

Merged
merged 1 commit into from
Jul 20, 2020
Merged

fix bastion infra test #142

merged 1 commit into from
Jul 20, 2020

Conversation

mvladev
Copy link

@mvladev mvladev commented Jul 20, 2020

How to categorize this PR?

/area control-plane
/kind bug
/priority normal
/platform aws

What this PR does / why we need it:

Fixes leftover bastion test
Which issue(s) this PR fixes:

#139 (comment)

Special notes for your reviewer:

Relevant prs #4 #139
Release note:

NONE

@mvladev mvladev requested a review from a team as a code owner July 20, 2020 05:36
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/aws Amazon web services platform/infrastructure priority/normal labels Jul 20, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2020
@mvladev mvladev requested a review from rfranzke July 20, 2020 05:36
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2020
@rfranzke
Copy link
Member

/test-single

@testmachinery
Copy link

testmachinery bot commented Jul 20, 2020 •
edited
Loading

Testrun: bot-test-single-bxwf8
Workflow: bot-test-single-bxwf8-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 7m14s    |
+---------------------+---------------------+-----------+----------+

rfranzke
rfranzke approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks Martin!

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jul 20, 2020
@rfranzke rfranzke merged commit b082a63 into gardener:master Jul 20, 2020
@mvladev mvladev deleted the fix-integratio-test branch July 20, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mvladev @rfranzke @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot