Expose MCM logs to the end-user

[vlvasilev]

How to categorize this PR?

/area logging
/kind enhancement
/platform aws

What this PR does / why we need it:
With this PR we allow end-users to see the MCM logs.
The logs will be visible after the merge of g/g#4387

Which issue(s) this PR fixes:
Рartially fixes g/g#4340

Special notes for your reviewer:

Release note:

machine-controller-manager logs are exposed to the end-users

[dkistner]

Does this PR depend on gardener/gardener#4387?
Or is it just without this merged and release in g/g the logs from mcm can't be displayed?

So far it looks good to me, but I'm not an expert in this area so would appreciate an opinion from @Kristian-ZH @istvanballok
/invite @Kristian-ZH @istvanballok

[vlvasilev]

Does this PR depend on gardener/gardener#4387?
Or is it just without this merged and release in g/g the logs from mcm can't be displayed?

This PR does not depend on gardener/gardener#4387.
The log will be stored in the Loki under user tenant but will be not visible until the above PR is merged.

[dkistner]

/lgtm
/hold due to ongoing release validation
cc @ialidzhikov

[ialidzhikov]

/invite @Kristian-ZH @istvanballok
for review

[gardener-robot]

@Kristian-ZH You have pull request review open invite, please check

[Kristian-ZH]

I see that you have created a dedicated rewrite_tag filter for the MCM, which is different approach than the previous (ccm, csi-driver), where all components were in one filter.

If we want to follow the new approach, maybe the CCM and the CSI-driver also should be splitted in two different filters.

[Kristian-ZH]

Also this PR: gardener/gardener#4387 is still not released.
If we want to keep the backwards-compatibility (older version of Gardener combined with newer version of this extension) we can also keep the old logic of exposing components for a few more releases.

[vlvasilev]

Also this PR: gardener/gardener#4387 is still not released.
If we want to keep the backwards-compatibility (older version of Gardener combined with newer version of this extension) we can also keep the old logic of exposing components for a few more releases.

Who said that I had removed the old logic?

I see that you have created a dedicated rewrite_tag filter for the MCM, which is different approach than the previous (ccm, csi-driver), where all components were in one filter.

The filter will become a lot of complex and hard to read so I decided to separate it.

[Kristian-ZH]

Who said that I had removed the old logic?

Opps, my bad...

The filter will become a lot of complex and hard to read so I decided to separate it.

Then what about creating a different filters for CCM and CSI-driver also. E.g. Each component to have its own filter ?

[vlvasilev]

Then what about creating a different filters for CCM and CSI-driver also. E.g. Each component to have its own filter ?

You are welcome to do it if you wish. I have no time for that.

[gardener-robot]

@Kristian-ZH You have pull request review open invite, please check

[vpnachev]

/lgtm