Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase cpu resources for csi-driver #421

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Increase cpu resources for csi-driver #421

merged 1 commit into from
Oct 5, 2021

Conversation

timebertt
Copy link
Member

@timebertt timebertt commented Oct 1, 2021 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area storage robustness
/kind enhancement
/platform aws

What this PR does / why we need it:

Increase the cpu limits for csi-driver-node/csi-driver to allow bigger bursts.
Also, set minAllowed=10m for cpu to prevent scaling down too much.

Which issue(s) this PR fixes:
Fixes #420

Special notes for your reviewer:

Release note:

The CPU limit of `csi-driver-node/csi-driver` is increased from 50m to 100m to allow bigger bursts.

@timebertt timebertt requested review from a team as code owners October 1, 2021 11:52
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 1, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 1, 2021
@gardener gardener deleted a comment from gardener-robot Oct 1, 2021
@gardener-robot gardener-robot added the area/storage Storage related label Oct 1, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 1, 2021
rfranzke
rfranzke approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 1, 2021
ialidzhikov
ialidzhikov approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit db7291e into gardener:master Oct 5, 2021
@ialidzhikov
Copy link
Member

@timebertt do we need similar change for the other provider extensions?

@timebertt timebertt deleted the enh/cpu-csi-driver branch October 6, 2021 06:44
@timebertt
Copy link
Member Author

@timebertt do we need similar change for the other provider extensions?

I haven't checked the resource consumption and requests/limits on other provider extensions, but I think @plkokanov put it on his list for this week.

@ialidzhikov ialidzhikov mentioned this pull request Nov 3, 2021
Merged
@rfranzke rfranzke mentioned this pull request Feb 19, 2022
Merged
This was referenced Feb 19, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related area/storage Storage related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

csi-driver-node is cpu throttled on highly concurrent volume operations
6 participants
@timebertt @ialidzhikov @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot