Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust metric name due to upgrading the kube-state-metrics component #566

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Adjust metric name due to upgrading the kube-state-metrics component #566

merged 1 commit into from
Aug 8, 2022

Conversation

istvanballok
Copy link
Member

@istvanballok istvanballok commented Jun 29, 2022 •
edited by dkistner
Loading

How to categorize this PR?

/area monitoring
/kind enhancement
/platform aws

What this PR does / why we need it:

Adjust metric name due to upgrading the kube-state-metrics component

See gardener/gardener#6224

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

/cc @wyb1 @ialidzhikov

Release note:

Adjust metric name due to upgrading the kube-state-metrics component

This version of provider-aws requires Gardener v1.51+.

@istvanballok istvanballok requested review from a team as code owners June 29, 2022 13:00
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 29, 2022
@gardener-robot gardener-robot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 29, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 29, 2022
wyb1
wyb1 approved these changes Jun 29, 2022
View reviewed changes
Copy link

@wyb1 wyb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 29, 2022
dkistner
dkistner approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dkistner dkistner merged commit 86fc639 into gardener:master Aug 8, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

@wyb1 wyb1 wyb1 approved these changes

Assignees
No one assigned
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@istvanballok @dkistner @wyb1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot