Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-20] Change StorageClass to WaitForFirstConsumer #597

Merged
merged 1 commit into from
Aug 25, 2022
Merged

[GEP-20] Change StorageClass to WaitForFirstConsumer #597

merged 1 commit into from
Aug 25, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Aug 25, 2022 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement
/platform aws

What this PR does / why we need it:
This PR changes the gardener.cloud-fast storage class do define volumeBindingMode: WaitForFirstConsumer. Scheduling HA shoot control-planes requires the volume creation to respect podAffinity and podAntiaffinities, so that stateful pods can either be schedules across zones or in a single zone only (zone pinning). Without this change, volumes are created in random zones which makes affected pods being stuck in Pending (ref).

Which issue(s) this PR fixes:
Fixes #399
Fixes partially gardener/gardener#6529

/cc @ialidzhikov

Release note:

The `gardener.cloud-fast` storage class is now deployed with `volumeBindingMode: WaitForFirstConsumer`. This change is required if stateful pods with volumes have a topology related `podAffinity` or `podAntiAffinity` defined, e.g. when Gardener creates control-planes for HA shoot clusters.

@timuthy timuthy requested review from a team as code owners August 25, 2022 07:58
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 25, 2022
ialidzhikov
ialidzhikov approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm

@ialidzhikov ialidzhikov merged commit 003f0af into gardener:master Aug 25, 2022
@timuthy timuthy deleted the enhancement.storage-class branch August 25, 2022 09:20
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/lgtm Needs approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/lgtm Needs approval for merging labels Aug 26, 2022
@timuthy timuthy mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using WaitForFirstConsumer volumeBindingMode for gardener.cloud-fast StorageClass
4 participants
@timuthy @ialidzhikov @gardener-robot-ci-3 @gardener-robot