Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang for builder image and linter to 1.19 #602

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Update golang for builder image and linter to 1.19 #602

merged 2 commits into from
Oct 11, 2022

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Sep 9, 2022 •
edited by kon-angelo
Loading

What this PR does / why we need it:

  • update golang for builder image: 1.18.3 -> 1.19.2
  • update golangci_lint: 1.45.2 -> 1.49 to prepare switching to golang 1.19 for verify step

Release note:

Update golang for builder image: `1.18.3` -> `1.19.2`

@MartinWeindel MartinWeindel requested review from a team as code owners September 9, 2022 09:19
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 9, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 9, 2022
@MartinWeindel MartinWeindel mentioned this pull request Sep 9, 2022
Merged
@shafeeqes shafeeqes mentioned this pull request Oct 7, 2022
Merged
acumino
acumino reviewed Oct 10, 2022
View reviewed changes
Makefile
@@ -43,6 +43,8 @@ SECRET_ACCESS_KEY_FILE := .kube-secrets/aws/secret_access_key.secret
#########################################

TOOLS_DIR := hack/tools
# temporarily until Gardener version has been revendored >= v1.54
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required now, the latest vendored gardener version is 1.56

Copy link
Contributor

@kon-angelo kon-angelo Oct 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still it doesn't harm to use a later golangci-lint version than gardener. We can remove it later.

@shafeeqes shafeeqes added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 10, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 10, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 11, 2022
kon-angelo
kon-angelo approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 11, 2022
@kon-angelo kon-angelo merged commit 9d183ef into gardener:master Oct 11, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino left review comments

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MartinWeindel @acumino @kon-angelo @shafeeqes @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot