-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang for builder image and linter to 1.19 #602
Update golang for builder image and linter to 1.19 #602
Conversation
@@ -43,6 +43,8 @@ SECRET_ACCESS_KEY_FILE := .kube-secrets/aws/secret_access_key.secret | |||
######################################### | |||
|
|||
TOOLS_DIR := hack/tools | |||
# temporarily until Gardener version has been revendored >= v1.54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required now, the latest vendored gardener version is 1.56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still it doesn't harm to use a later golangci-lint version than gardener. We can remove it later.
7201088
to
6921d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
1.18.3
->1.19.2
1.45.2
->1.49
to prepare switching to golang 1.19 for verify stepRelease note: