-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable custom aws route controller manager if no provider config is specified. #612
Enable custom aws route controller manager if no provider config is specified. #612
Conversation
@ScheererJ Thank you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a unit test for this case so that we don't regress it in the future? :)
…pecified. The custom aws route controller manager is essential to the shoot cluster working without overlay network. Therefore, it needs to be enabled regardless if there is a provider configuration or not. Otherwise, shoot clusters will get no overlay, but no pod routes.
0f5bd88
to
f28fe0d
Compare
A corresponding test has been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area networking
/kind bug
/platform aws
What this PR does / why we need it:
Enable custom aws route controller manager if no provider config is specified.
The custom aws route controller manager is essential to the shoot cluster working without overlay network. Therefore, it needs to be enabled regardless if there is a provider configuration or not. Otherwise, shoot clusters will get no overlay, but no pod routes.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Release note: