Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the mutation of the Controlplane webhook #620

Closed
wants to merge 1 commit into from
Closed

Fix the mutation of the Controlplane webhook #620

wants to merge 1 commit into from

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Sep 26, 2022 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind bug
/platform aws

What this PR does / why we need it:
Fix an issue where the previous mutation of the controlplane webhook would be reverted in subsequent reconciles.

Which issue(s) this PR fixes:
Fixes #619

Special notes for your reviewer:

Release note:

Fix an issue where the previous mutation of the controlplane webhook would be reverted in subsequent reconciles.

@kon-angelo kon-angelo requested review from a team as code owners September 26, 2022 11:07
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 26, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 26, 2022
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 26, 2022
@kon-angelo kon-angelo closed this Sep 27, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/aws Amazon web services platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
4 participants
@kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot